← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1891315] [NEW] netinfo.py does not handle all link formats

 

Public bug reported:

Using nocloud
Following output from ip show addr is not processed properly (see can0 link/can), causing failure in other interface setup.

================================
ip addr show
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host 
       valid_lft forever preferred_lft forever
2: sit0@NONE: <NOARP> mtu 1480 qdisc noop state DOWN group default qlen 1000
    link/sit 0.0.0.0 brd 0.0.0.0
3: can0: <NOARP,ECHO> mtu 16 qdisc noop state DOWN group default qlen 10
    link/can 
4: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP group default qlen 1000
    link/ether c6:fc:89:b6:a9:23 brd ff:ff:ff:ff:ff:ff
    inet 192.168.0.64/16 brd 192.168.255.255 scope global dynamic eth0
       valid_lft 12689sec preferred_lft 12689sec
    inet6 fe80::c4fc:89ff:feb6:a923/64 scope link 
       valid_lft forever preferred_lft forever
5: eth1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP group default qlen 1000
    link/ether 2a:f3:e3:89:da:bb brd ff:ff:ff:ff:ff:ff
    inet 10.74.90.86/24 brd 10.74.90.255 scope global eth1
       valid_lft forever preferred_lft forever
    inet6 fe80::28f3:e3ff:fe89:dabb/64 scope link 
       valid_lft forever preferred_lft forever
6: docker0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN group default 
    link/ether 02:42:23:bf:3a:e1 brd ff:ff:ff:ff:ff:ff
    inet 172.17.0.1/16 brd 172.17.255.255 scope global docker0
       valid_lft forever preferred_lft forever
================================

Proposal is to add following at  https://github.com/canonical/cloud-
init/blob/3c551f6ebc12f7729a2755c89b19b9000e27cc88/cloudinit/netinfo.py#L82:

82a82,85
>                 m = re.match(
>                     r'\s+link/(?P<link_type>\S+).*', line)
> 
>             if not m:

** Affects: cloud-init
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to cloud-init.
https://bugs.launchpad.net/bugs/1891315

Title:
  netinfo.py does not handle all link formats

Status in cloud-init:
  New

Bug description:
  Using nocloud
  Following output from ip show addr is not processed properly (see can0 link/can), causing failure in other interface setup.

  ================================
  ip addr show
  1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
      link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
      inet 127.0.0.1/8 scope host lo
         valid_lft forever preferred_lft forever
      inet6 ::1/128 scope host 
         valid_lft forever preferred_lft forever
  2: sit0@NONE: <NOARP> mtu 1480 qdisc noop state DOWN group default qlen 1000
      link/sit 0.0.0.0 brd 0.0.0.0
  3: can0: <NOARP,ECHO> mtu 16 qdisc noop state DOWN group default qlen 10
      link/can 
  4: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP group default qlen 1000
      link/ether c6:fc:89:b6:a9:23 brd ff:ff:ff:ff:ff:ff
      inet 192.168.0.64/16 brd 192.168.255.255 scope global dynamic eth0
         valid_lft 12689sec preferred_lft 12689sec
      inet6 fe80::c4fc:89ff:feb6:a923/64 scope link 
         valid_lft forever preferred_lft forever
  5: eth1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP group default qlen 1000
      link/ether 2a:f3:e3:89:da:bb brd ff:ff:ff:ff:ff:ff
      inet 10.74.90.86/24 brd 10.74.90.255 scope global eth1
         valid_lft forever preferred_lft forever
      inet6 fe80::28f3:e3ff:fe89:dabb/64 scope link 
         valid_lft forever preferred_lft forever
  6: docker0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN group default 
      link/ether 02:42:23:bf:3a:e1 brd ff:ff:ff:ff:ff:ff
      inet 172.17.0.1/16 brd 172.17.255.255 scope global docker0
         valid_lft forever preferred_lft forever
  ================================

  Proposal is to add following at  https://github.com/canonical/cloud-
  init/blob/3c551f6ebc12f7729a2755c89b19b9000e27cc88/cloudinit/netinfo.py#L82:

  82a82,85
  >                 m = re.match(
  >                     r'\s+link/(?P<link_type>\S+).*', line)
  > 
  >             if not m:

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-init/+bug/1891315/+subscriptions


Follow ups