yahoo-eng-team team mailing list archive

[OpenStack Infra <1891352@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/745933
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=737dfca83c8d347ef22eab7afca4057ce5f03f20
Submitter: Zuul
Branch:    master

commit 737dfca83c8d347ef22eab7afca4057ce5f03f20
Author: Dan Smith <dansmith@xxxxxxxxxx>
Date:   Wed Aug 12 09:22:46 2020 -0700

    Fix import failure status reporting when all_stores_must_succeed=True
    
    As described in the referenced bug, if a store fails with
    all_stores_must_succeed=True, we never add that store to the
    failed list, nor remove it from the pending-import list, leaving a
    polling client to wait forever. This fixes that by making the revert
    handler of the import task do that if we are the one that failed.
    
    Closes-Bug: #1891352
    Change-Id: I3571960bbfb4f8f0a716937b541f5b1594cd0e16


** Changed in: glance
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1891352

Title:
  Failed import of one store will remain in progress forever if
  all_stores_must_succeed=True

Status in Glance:
  Fix Released

Bug description:
  If import is called with all_stores_must_succeed=True and a store
  fails during set_image_data(), the store will remain in
  os_glance_importing_stores forever, never going into the
  os_glance_failed_import list. This means a polling client will never
  notice that the import failed. Further, if multiple stores are
  included in the import, and the failure happens in the later stores,
  the revert process will remove the earlier stores (after they had
  already been reported as available in stores). This means a polling
  client doing an import on an image already in store1 to
  store2,store3,store4 will see the following progression:

  stores=store1;os_glance_importing_to_stores=store2,store3,store4

  stores=store1,store2;os_glance_importing_to_stores=store3,store4

  stores=store1,store2,store3;os_glance_importing_to_stores=store4

  stores=store1,store2;os_glance_importing_to_stores=store4

  stores=store1;os_glance_importing_to_stores=store4

  The last line, forever, and never see anything in
  os_glance_failed_import

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1891352/+subscriptions