yahoo-eng-team team mailing list archive

[OpenStack Infra <1891898@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/745512
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4ba23996d036914f2ab7889db9af4ce6997ebc48
Submitter: Zuul
Branch:    master

commit 4ba23996d036914f2ab7889db9af4ce6997ebc48
Author: Lee Yarwood <lyarwood@xxxxxxxxxx>
Date:   Mon Aug 10 11:00:55 2020 +0100

    libvirt: Mock LoopingCallBase._sleep in rbd tests
    
    The tests previously mocked eventlet.greenthread.sleep directly but
    I62e9f1a7cde8846be368fbec58b8e0825ce02079 removed this call from
    LoopingCallBase._sleep in oslo.service 1.32.1. Just mock the _sleep
    method directly to avoid us ever spinning in tests on this again.
    
    Closes-Bug: #1891898
    Change-Id: I0872ee16e9fc49c988fe588f029ab71f429790f5


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1891898

Title:
  nova.tests.unit.virt.libvirt.storage.test_rbd.RbdTestCase.test_cleanup_volumes_fail_*
  tests take ~55 seconds to complete

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Description
  ===========
  $summary, this appears due to changes in oslo.service resulting in the tests actually waiting:

  https://zuul.opendev.org/t/openstack/build/95c8f5f4d9ac4dc2b1874292bfb11b8b/log
  /job-output.txt#18821

  2020-08-13 18:29:50.526776 | ubuntu-bionic | {6} nova.tests.unit.virt.libvirt.storage.test_rbd.RbdTestCase.test_cleanup_volumes_fail_not_found [55.049820s] ... ok
  2020-08-13 18:30:45.583462 | ubuntu-bionic | {6} nova.tests.unit.virt.libvirt.storage.test_rbd.RbdTestCase.test_cleanup_volumes_fail_snapshots [55.056473s] ... ok

  
  Steps to reproduce
  ==================
  $ tox -e py38 nova.tests.unit.virt.libvirt.storage.test_rbd.RbdTestCase.test_cleanup_volumes_fail

  Expected result
  ===============
  Tests complete almost instantly.

  Actual result
  =============
  Tests take ~55 seconds each to complete.

  Environment
  ===========
  1. Exact version of OpenStack you are running. See the following
    list for all releases: http://docs.openstack.org/releases/

     master

  2. Which hypervisor did you use?
     (For example: Libvirt + KVM, Libvirt + XEN, Hyper-V, PowerKVM, ...)
     What's the version of that?

     N/A

  2. Which storage type did you use?
     (For example: Ceph, LVM, GPFS, ...)
     What's the version of that?

     N/A

  3. Which networking type did you use?
     (For example: nova-network, Neutron with OpenVSwitch, ...)

     N/A

  Logs & Configs
  ==============
  Provided above.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1891898/+subscriptions