yahoo-eng-team team mailing list archive

[Rikimaru Honjo <1892471@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

[Issue]

[compute]consecutive_build_service_disable_threshold option was added by
the following patch.

https://review.opendev.org/#/c/463597/

The nova-compute's service record was automatically disabled if we consecutively failed to build a certain number of instances after metging the patch.
At that time consecutive_build_service_disable_threshold was used as threshold.

But, the following patch deleted the feature to automatically disable
the service record.

https://review.opendev.org/#/c/572195/

This option's behavior after merging the above patch is this:

* Any positive integer enables reporting build failures.
* Zero to disable reporting build failures.

consecutive_build_service_disable_threshold is used as a boolean value now. There is no difference of behavior between 1 and higher value.
Therefore, I think that consecutive_build_service_disable_"threshold" is an inappropriate name in current nova.

[Improvement plan]

Update the option name.

e.g.
[compute]enable_reporting_of_build_failures

** Affects: nova
     Importance: Undecided
         Status: New

** Description changed:

  [Issue]
  
- [compute]consecutive_build_service_disable_threshold option was added in
+ [compute]consecutive_build_service_disable_threshold option was added by
  the following patch.
  
  https://review.opendev.org/#/c/463597/
  
  The nova-compute's service record was automatically disabled if we consecutively failed to build a certain number of instances after metging the patch.
  At that time consecutive_build_service_disable_threshold was used as threshold.
  
  But, the following patch deleted the feature to automatically disable
  the service record.
  
  https://review.opendev.org/#/c/572195/
  
  This option's behavior after merging the above patch is this:
  
  * Any positive integer enables reporting build failures.
  * Zero to disable reporting build failures.
  
  consecutive_build_service_disable_threshold is used as a boolean value now. There is no difference of behavior between 1 and higher value.
  Therefore, I think that consecutive_build_service_disable_threshold is an an inappropriate name in current nova.
  
  [Improvement plan]
  
  Update the option name.
  
  e.g.
  [compute]enable_reporting_of_build_failures

** Description changed:

  [Issue]
  
  [compute]consecutive_build_service_disable_threshold option was added by
  the following patch.
  
  https://review.opendev.org/#/c/463597/
  
  The nova-compute's service record was automatically disabled if we consecutively failed to build a certain number of instances after metging the patch.
  At that time consecutive_build_service_disable_threshold was used as threshold.
  
  But, the following patch deleted the feature to automatically disable
  the service record.
  
  https://review.opendev.org/#/c/572195/
  
  This option's behavior after merging the above patch is this:
  
  * Any positive integer enables reporting build failures.
  * Zero to disable reporting build failures.
  
  consecutive_build_service_disable_threshold is used as a boolean value now. There is no difference of behavior between 1 and higher value.
- Therefore, I think that consecutive_build_service_disable_threshold is an an inappropriate name in current nova.
+ Therefore, I think that consecutive_build_service_disable_"threshold" is an inappropriate name in current nova.
  
  [Improvement plan]
  
  Update the option name.
  
  e.g.
  [compute]enable_reporting_of_build_failures

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1892471

Title:
  consecutive_build_service_disable_threshold option is an inappropriate
  name in current nova

Status in OpenStack Compute (nova):
  New

Bug description:
  [Issue]

  [compute]consecutive_build_service_disable_threshold option was added
  by the following patch.

  https://review.opendev.org/#/c/463597/

  The nova-compute's service record was automatically disabled if we consecutively failed to build a certain number of instances after metging the patch.
  At that time consecutive_build_service_disable_threshold was used as threshold.

  But, the following patch deleted the feature to automatically disable
  the service record.

  https://review.opendev.org/#/c/572195/

  This option's behavior after merging the above patch is this:

  * Any positive integer enables reporting build failures.
  * Zero to disable reporting build failures.

  consecutive_build_service_disable_threshold is used as a boolean value now. There is no difference of behavior between 1 and higher value.
  Therefore, I think that consecutive_build_service_disable_"threshold" is an inappropriate name in current nova.

  [Improvement plan]

  Update the option name.

  e.g.
  [compute]enable_reporting_of_build_failures

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1892471/+subscriptions