← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1754677] Re: Unable to remove an assignment from domain and project

 

Reviewed:  https://review.opendev.org/737225
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=28faa24e68467f7c10e00e433fec61914e172ca1
Submitter: Zuul
Branch:    master

commit 28faa24e68467f7c10e00e433fec61914e172ca1
Author: Vishakha Agarwal <agarwalvishakha18@xxxxxxxxx>
Date:   Mon Jun 22 12:58:00 2020 +0530

    Remove an assignment from domain and project
    
    When you setup a user with a role assignment on a domain
    and then a role assignment on a project "acting as a domain",
    you can't actually remove them. The database throws you the
    error "Multiple rows were found for one()" since it gets two
    results for "actor_id" with the same "target_id".
    
    This patch fixes this problem by filtering the database query
    by "type" field to determine whether it is a user domain relation
    or a user project and then removing the assignment.
    
    Change-Id: Ife92a3c9e0982baafb4224882681c0855f573580
    Closes-Bug: #1754677


** Changed in: keystone
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1754677

Title:
  Unable to remove an assignment from domain and project

Status in OpenStack Identity (keystone):
  Fix Released

Bug description:
  When you setup a user with a role assignment on a domain and then a
  role assignment on a project "acting as a domain", you can't actually
  remove them. The following pastes sets up the environment:

  http://paste.openstack.org/show/695978/

  Which results in the following when a user tries to remove either of
  those assignments:

  http://paste.openstack.org/show/696013/

  And the resulting trace:

  http://paste.openstack.org/show/695994/

  It appears the issue is because somewhere in the assignment code we're
  only expecting a single assignment to be returned for us to delete,
  which isn't the case here and causes ambiguity.

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1754677/+subscriptions


References