← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1893656] Re: [ovn] Limit the number of metadata workers

 

Reviewed:  https://review.opendev.org/750185
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f3a8e1547d444a1139d29faef3e81a8addb99769
Submitter: Zuul
Branch:    master

commit f3a8e1547d444a1139d29faef3e81a8addb99769
Author: Lucas Alvares Gomes <lucasagomes@xxxxxxxxx>
Date:   Mon Sep 7 15:38:23 2020 +0100

    [OVN][OVS] Different metadata_workers default based on driver
    
    Both drivers have different approaches when it comes to the metatada
    agent, for one the metadata agent for ML2/OVN runs on the compute nodes
    (it's distributed) instead of the controller nodes.
    
    The previous default of "<# of CPUs> / 2" did not make sense for ML2/OVN
    and if left unchanged could result in scalation problems because of the
    number of connections to the OVSDB Southbound database, as seeing in
    this email thread for example [0].
    
    This patch puts a placeholder value (None) on the default field of
    the "metadata_workers" config by not setting it immediately and then
    conditionally set the default value based on each driver:
    
    * ML2/OVS defaults to <# CPUs> // 2, as before.
    * ML2/OVN defaults to 2, as suggested in the bug description and also
      what's default in TripleO for the OVN driver.
    
    [0]
    http://lists.openstack.org/pipermail/openstack-discuss/2020-September/016960.html
    
    Change-Id: I60d5dfef38dc130b47668604c04299b9d23b59b6
    Closes-Bug: #1893656
    Signed-off-by: Lucas Alvares Gomes <lucasagomes@xxxxxxxxx>


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1893656

Title:
  [ovn] Limit the number of metadata workers

Status in charm-layer-ovn:
  Fix Released
Status in charm-ovn-chassis:
  Fix Committed
Status in neutron:
  Fix Released

Bug description:
  The OVN Metadata agent reuses the metadata_workers config option from
  the ML2/OVS Metadata agent.

  However, it makes sense to split the option as the way both agents
  work is totally different so it makes sense to have different
  defaults.

  In OVN, the Metadata Agent will run in compute nodes while in the
  ML2/OVS case it usually runs in controllers so the scenario is totally
  different.

  We defaulted to 2 in TripleO and this commit includes further details:

  https://opendev.org/openstack/puppet-
  neutron/commit/847f434140ee8435ee842801748a0deccdff8155

To manage notifications about this bug go to:
https://bugs.launchpad.net/charm-layer-ovn/+bug/1893656/+subscriptions


References