yahoo-eng-team team mailing list archive

[OpenStack Infra <1893305@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/749739
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=2f9014586f90af96e39e882cc23f8cf012d28947
Submitter: Zuul
Branch:    master

commit 2f9014586f90af96e39e882cc23f8cf012d28947
Author: manchandavishal <manchandavishal143@xxxxxxxxx>
Date:   Thu Sep 3 13:46:58 2020 +0000

    Refactor error messages.
    
    When we didn't pass the redirect parameter in exceptions.handle() then
    '_alert_message.html' template is used to displays the error messages.
    If details are empty in a case but it still shows the 'Details' href
    which is wrong and this patch adds a condition in that template to fix
    that issue.
    
    This patch also fix review comment of change-id
    5081359295e5311ca725e80efa0bc4b2ec811a0e and define a constant for
    '\u2026' and use it in all files.
    
    Note: '\u2026' is used for unicode glyph representing '...'.
    
    Closes-Bug: #1893305
    
    Partially-Implements blueprint refactor-error-messages
    
    Change-Id: If4409a1245c983fb51712c6c817c11e884916694
    Co-Author: Ivan Kolodyazhny <e0ne@xxxxxxxxx>


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1893305

Title:
  Details href still displayed when details is empty and redirect is
  false.

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Refactor error messages patch https://review.opendev.org/#/c/708069/ doesn't covers a scenerio when
  details is empty and redirect is false. It sill display the 'Details' href which is wrong.

  When we didn't pass redirect parametr in excecption.handle() then '_alert_message.html' template is
  used for displays the error mesage. We have to add some codition here https://review.opendev.org/#/c/708069/21/horizon/templates/horizon/client_side/_alert_message.html@18 to fix it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1893305/+subscriptions