← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1895671] Re: [OVN] test_add_interface_in_use fail with OVN

 

Reviewed:  https://review.opendev.org/752057
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f2643f27fb617a517be95138246331d8556c0cc3
Submitter: Zuul
Branch:    master

commit f2643f27fb617a517be95138246331d8556c0cc3
Author: Lucas Alvares Gomes <lucasagomes@xxxxxxxxx>
Date:   Tue Sep 15 15:30:22 2020 +0100

    [OVN] Fix test_add_interface_in_use negative test
    
    While fixing https://bugs.launchpad.net/neutron/+bug/1876148 we've made
    the add_router_interface method idempotent and it no longer raised a
    Conflict if the same interface was added twice, this broke the
    test_add_interface_in_use from neutron-tempest-pluign.
    
    Change-Id: I76d46a4c3c8af166e022894a5693d5c78555ea50
    Closes-Bug: #1895671
    Signed-off-by: Lucas Alvares Gomes <lucasagomes@xxxxxxxxx>


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1895671

Title:
  [OVN] test_add_interface_in_use fail with OVN

Status in neutron:
  Fix Released

Bug description:
  The test neutron-tempest-plugin test_add_interface_in_use fails when
  ml2/ovn is used.

  Apparently this behavior is a consequence of this fix:
  https://review.opendev.org/#/c/724930, reverting the patch makes it
  work again BUT, reverting it will re-introduce the original bug that
  the patch fixed.

  Basically what happens is that now the add_router_interface() method
  from ml2/ovn will never raise the PortInUse exception if you try to
  add the same interface twice. The test_add_interface_in_use is a
  negative test that validates this behavior.

  This idempotent behavior was introduced because of the maintenance
  thread but I believe that we can make the API behave as expected
  (raising the PortInUse) and the maintenance code can handle this
  exception and ignore it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1895671/+subscriptions


References