← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1894825] Re: placement allocation update accepts only integers from 1

 

Reviewed:  https://review.opendev.org/750349
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=a61f9553d2074d160ac384313971421b7f063765
Submitter: Zuul
Branch:    master

commit a61f9553d2074d160ac384313971421b7f063765
Author: elajkat <lajos.katona@xxxxxxxx>
Date:   Tue Sep 8 13:08:45 2020 +0200

    remove rc from allocation dict if value is 0
    
    update_qos_minbw_allocation now deletes the resource class keys if the
    value for the give resource class is zero, as placement can't handle 0
    value updates, see the referenced story.
    
    Change-Id: Iaf23eb313507139c2de76146b82d148bcce9b3d6
    Closes-Bug: #1894825
    Related-Bug: #1882804
    Story: 2008111


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1894825

Title:
  placement allocation update accepts only integers from 1

Status in neutron:
  Fix Released

Bug description:
  update_qos_minbw_allocation (see: https://opendev.org/openstack/neutron-lib/src/commit/245e005d1bbb9af5e57ff600fb97b2a13c85c83b/neutron_lib/placement/client.py ) assumes that placement allocation records can be updated by 0 (like: 
  {
    "allocations": {
      "4e061c03-611e-4caa-bf26-999dcff4284e": {
        "resources": {
          "NET_BW_EGR_KILOBIT_PER_SEC": 0
        }
      }
  }

  ), 
  but that is not possible now, the way to do this is to delete the resource class,
  see the storyboard story for this:
  https://storyboard.openstack.org/#!/story/2008111

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1894825/+subscriptions


References