yahoo-eng-team team mailing list archive

[Corey Bryant <1896506@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Presumably the default of keepalived_use_no_track default=True breaks
bionic deploys and the patch [1] has been backported to several bionic-
based stable branches with a conflicting default config value; it's been
backported back to stable/rocky.

[1] https://review.opendev.org/#/c/747862/1

This doesn't seem like a good backport to stable branches without having
some logic in it that detects the version of keepalived and sets the
default appropriately based on that version.

More discussion with slaweq from #openstack-neutron:

coreycb> Corey Bryant slaweq: about this backport, will it break deployments that are on bionic? https://review.opendev.org/#/c/747857/1
10:40 AM I don't think there are any stein deployments on focal
11:06 AM
<slaweq> Sławek Kapłoński coreycb: what keepalived version is available on Bionic?
11:06 AM coreycb: ahh, ok it's 1.x
11:06 AM
<coreycb> Corey Bryant slaweq: correct 1.x
11:06 AM
<slaweq> Sławek Kapłoński so it should be set to False on Bionic
11:10 AM → armax joined  ⇐ priteau quit
11:12 AM
<coreycb> Corey Bryant slaweq: it would be really nice to if we could detect the version and set it appropriately

Can we revert this for all releases prior to Ussuri?

For Ubuntu, Ussuri is available by default with Focal, but we also
backport Ussuri to bionic so we would have to change the default for
keepalived_use_no_track default to False for bionic.

** Affects: neutron
     Importance: Undecided
         Status: New

** Affects: neutron (Ubuntu)
     Importance: Undecided
         Status: New

** Also affects: neutron
   Importance: Undecided
       Status: New

** Description changed:

  Presumably the default of keepalived_us_no_track default=True breaks
  bionic deploys and the patch [1] has been backported to several bionic-
- based stable branches; it's been backported back to stable/rocky.
+ based stable branches with a conflicting default config value; it's been
+ backported back to stable/rocky.
  
  [1] https://review.opendev.org/#/c/747862/1
  
  This doesn't seem like a good backport to stable branches without having
  some logic in it that detects the version of keepalived and sets the
  default appropriately based on that version.
  
  More discussion with slaweq from #openstack-neutron:
  
  coreycb> Corey Bryant slaweq: about this backport, will it break deployments that are on bionic? https://review.opendev.org/#/c/747857/1
  10:40 AM I don't think there are any stein deployments on focal
- 11:06 AM 
+ 11:06 AM
  <slaweq> Sławek Kapłoński coreycb: what keepalived version is available on Bionic?
  11:06 AM coreycb: ahh, ok it's 1.x
- 11:06 AM 
+ 11:06 AM
  <coreycb> Corey Bryant slaweq: correct 1.x
- 11:06 AM 
+ 11:06 AM
  <slaweq> Sławek Kapłoński so it should be set to False on Bionic
- 11:10 AM → armax joined  ⇐ priteau quit  
- 11:12 AM 
+ 11:10 AM → armax joined  ⇐ priteau quit
+ 11:12 AM
  <coreycb> Corey Bryant slaweq: it would be really nice to if we could detect the version and set it appropriately

** Description changed:

  Presumably the default of keepalived_us_no_track default=True breaks
  bionic deploys and the patch [1] has been backported to several bionic-
  based stable branches with a conflicting default config value; it's been
  backported back to stable/rocky.
  
  [1] https://review.opendev.org/#/c/747862/1
  
  This doesn't seem like a good backport to stable branches without having
  some logic in it that detects the version of keepalived and sets the
  default appropriately based on that version.
  
  More discussion with slaweq from #openstack-neutron:
  
  coreycb> Corey Bryant slaweq: about this backport, will it break deployments that are on bionic? https://review.opendev.org/#/c/747857/1
  10:40 AM I don't think there are any stein deployments on focal
  11:06 AM
  <slaweq> Sławek Kapłoński coreycb: what keepalived version is available on Bionic?
  11:06 AM coreycb: ahh, ok it's 1.x
  11:06 AM
  <coreycb> Corey Bryant slaweq: correct 1.x
  11:06 AM
  <slaweq> Sławek Kapłoński so it should be set to False on Bionic
  11:10 AM → armax joined  ⇐ priteau quit
  11:12 AM
  <coreycb> Corey Bryant slaweq: it would be really nice to if we could detect the version and set it appropriately
+ 
+ 
+ Can we revert this for all releases prior to Ussuri?
+ 
+ For Ubuntu, Ussuri is available by default with Focal, but we also
+ backport Ussuri to bionic so we would have to change the default for
+ keepalived_us_no_track default to False for bionic.

** Summary changed:

- keepalived_us_no_track default=True breaks bionic deploys
+ keepalived_use_no_track default=True breaks bionic deploys

** Description changed:

- Presumably the default of keepalived_us_no_track default=True breaks
+ Presumably the default of keepalived_use_no_track default=True breaks
  bionic deploys and the patch [1] has been backported to several bionic-
  based stable branches with a conflicting default config value; it's been
  backported back to stable/rocky.
  
  [1] https://review.opendev.org/#/c/747862/1
  
  This doesn't seem like a good backport to stable branches without having
  some logic in it that detects the version of keepalived and sets the
  default appropriately based on that version.
  
  More discussion with slaweq from #openstack-neutron:
  
  coreycb> Corey Bryant slaweq: about this backport, will it break deployments that are on bionic? https://review.opendev.org/#/c/747857/1
  10:40 AM I don't think there are any stein deployments on focal
  11:06 AM
  <slaweq> Sławek Kapłoński coreycb: what keepalived version is available on Bionic?
  11:06 AM coreycb: ahh, ok it's 1.x
  11:06 AM
  <coreycb> Corey Bryant slaweq: correct 1.x
  11:06 AM
  <slaweq> Sławek Kapłoński so it should be set to False on Bionic
  11:10 AM → armax joined  ⇐ priteau quit
  11:12 AM
  <coreycb> Corey Bryant slaweq: it would be really nice to if we could detect the version and set it appropriately
  
- 
  Can we revert this for all releases prior to Ussuri?
  
  For Ubuntu, Ussuri is available by default with Focal, but we also
  backport Ussuri to bionic so we would have to change the default for
- keepalived_us_no_track default to False for bionic.
+ keepalived_use_no_track default to False for bionic.

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1896506

Title:
  keepalived_use_no_track default=True breaks bionic deploys

Status in neutron:
  New
Status in neutron package in Ubuntu:
  New

Bug description:
  Presumably the default of keepalived_use_no_track default=True breaks
  bionic deploys and the patch [1] has been backported to several
  bionic-based stable branches with a conflicting default config value;
  it's been backported back to stable/rocky.

  [1] https://review.opendev.org/#/c/747862/1

  This doesn't seem like a good backport to stable branches without
  having some logic in it that detects the version of keepalived and
  sets the default appropriately based on that version.

  More discussion with slaweq from #openstack-neutron:

  coreycb> Corey Bryant slaweq: about this backport, will it break deployments that are on bionic? https://review.opendev.org/#/c/747857/1
  10:40 AM I don't think there are any stein deployments on focal
  11:06 AM
  <slaweq> Sławek Kapłoński coreycb: what keepalived version is available on Bionic?
  11:06 AM coreycb: ahh, ok it's 1.x
  11:06 AM
  <coreycb> Corey Bryant slaweq: correct 1.x
  11:06 AM
  <slaweq> Sławek Kapłoński so it should be set to False on Bionic
  11:10 AM → armax joined  ⇐ priteau quit
  11:12 AM
  <coreycb> Corey Bryant slaweq: it would be really nice to if we could detect the version and set it appropriately

  Can we revert this for all releases prior to Ussuri?

  For Ubuntu, Ussuri is available by default with Focal, but we also
  backport Ussuri to bionic so we would have to change the default for
  keepalived_use_no_track default to False for bionic.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1896506/+subscriptions