yahoo-eng-team team mailing list archive

[OpenStack Infra <1895663@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/752067
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=68c202d38ba0648c8a71a7e4c3771ea6c6f60651
Submitter: Zuul
Branch:    master

commit 68c202d38ba0648c8a71a7e4c3771ea6c6f60651
Author: Grégoire Unbekandt <gregoire.unbekandt@xxxxxxxxx>
Date:   Tue Sep 15 15:19:43 2020 +0200

    Image import "web-download" check downloaded size
    
    If the downloaded data size is different from the expected one, the
    task "web-download" in the image import process will now fail.
    
    Change-Id: Ie260486d795a6f4af1632f6f3708abc92fb47a3a
    Closes-Bug: #1895663


** Changed in: glance
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1895663

Title:
  Image import "web-download" doesn't check on download size

Status in Glance:
  Fix Released

Bug description:
  When using the image import "web-download" the downloaded data size is
  not checked.

  This can result in corrupted images in case of network failures or if
  the source breaks the connection. In such a case Glance should
  interrupt the process instead of continuing the import.

  If the server hosting the data supports the header "Content-Length",
  Glance should rely on it. All necessaries informations are provided as
  "store.add" already returns the written size.

  https://github.com/openstack/glance/blob/master/glance/async_/flows/_internal_plugins/web_download.py#L120

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1895663/+subscriptions