yahoo-eng-team team mailing list archive

[OpenStack Infra <1795950@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/607680
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=922c2ed5adbfedba17324174369cfa2329e999ab
Submitter: Zuul
Branch:    master

commit 922c2ed5adbfedba17324174369cfa2329e999ab
Author: Victor Coutellier <victor.coutellier@xxxxxxxxx>
Date:   Wed Oct 3 20:09:17 2018 +0200

    Fix cleaning of web-download image import
    
    If import flow fail before reaching the end it never execute
    the _DeleteFromFS task and the node_staging_uri is never cleaned up.
    
    Implement the revert() function of the _WebDownload task to remove the
    temporary file.
    
    Change-Id: I6dd6a6e2a95a5bd17a80b6256852bb9fac5fa339
    Co-Authored-By: Grégoire Unbekandt <gregoire.unbekandt@xxxxxxxxx>
    Co-Authored-By: Abhishek Kekane <akekane@xxxxxxxxxx>
    Closes-Bug: #1795950


** Changed in: glance
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1795950

Title:
  Fix cleaning of web-download image import in node_staging_uri

Status in Glance:
  Fix Released

Bug description:
  If glance api import flow fail before reaching the end of the import via web-download, it never execute the _DeleteFromFS task and keep the file in the node_staging_uri directory on the API node.
  So after many fail import, node_staging_uri is never cleaned up.

  The solution will be to implement the revert() function of the
  _WebDownload task in order to remove the temporary file.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1795950/+subscriptions