← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1897253] [NEW] Password requirement check on user create / change incomplete

 

Public bug reported:

Version: OpenStack Horizon stable/ussri (18.3.2-12-gc348787fa)

** Action **

When doing:
- create user, or
- change password
using a password that does not meet the keystone requirements.


** Expected behaviour **

- Horizon interface should print error with "password_regex_description" contents.
- Input field should not be closed, but left open, so user can fix the problem.
- Error logs should report the original warning.


** Actual behaviour **

- If there is a line feed in the description, the regex_description is not parsed (uses re.MULTILINE instead of re.DOTALL).
- The edit-window is closed instead of left open for editing (missing "return False").
- The log message is eaten by ignore=True, making it harder to debugging problems.
- The create-user window simply reported "Error: Unable to create user." without any further info, closing the edit-window.


** Related bugs **

- #1838003 - "Horizon hides password requirements"


** Fixes **

-
https://github.com/ossobv/horizon/commit/4b9a0d8cf84e85e8b93092818b52c7fb859b310b


Cheers,
Walter Doekes
OSSO B.V.

** Affects: horizon
     Importance: Undecided
         Status: New

** Patch added: "suggested fix"
   https://bugs.launchpad.net/bugs/1897253/+attachment/5414129/+files/4b9a0d8cf84e85e8b93092818b52c7fb859b310b.patch

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1897253

Title:
  Password requirement check on user create / change incomplete

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  Version: OpenStack Horizon stable/ussri (18.3.2-12-gc348787fa)

  ** Action **

  When doing:
  - create user, or
  - change password
  using a password that does not meet the keystone requirements.

  
  ** Expected behaviour **

  - Horizon interface should print error with "password_regex_description" contents.
  - Input field should not be closed, but left open, so user can fix the problem.
  - Error logs should report the original warning.

  
  ** Actual behaviour **

  - If there is a line feed in the description, the regex_description is not parsed (uses re.MULTILINE instead of re.DOTALL).
  - The edit-window is closed instead of left open for editing (missing "return False").
  - The log message is eaten by ignore=True, making it harder to debugging problems.
  - The create-user window simply reported "Error: Unable to create user." without any further info, closing the edit-window.

  
  ** Related bugs **

  - #1838003 - "Horizon hides password requirements"

  
  ** Fixes **

  -
  https://github.com/ossobv/horizon/commit/4b9a0d8cf84e85e8b93092818b52c7fb859b310b

  
  Cheers,
  Walter Doekes
  OSSO B.V.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1897253/+subscriptions