yahoo-eng-team team mailing list archive

[OpenStack Infra <1896827@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/753833
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=be3669258cb6f8a6c43b2f016a344185075fa544
Submitter: Zuul
Branch:    master

commit be3669258cb6f8a6c43b2f016a344185075fa544
Author: Flavio Fernandes <flaviof@xxxxxxxxxx>
Date:   Wed Sep 23 15:28:55 2020 -0400

    [OVN] update_port should not remove values from external_ids
    
    Prior to this patch, the OVNClient implementation for neutron's
    update_port was setting the external_ids of the affected logical
    switch port to a hard-coded dictionary. This meant that any key
    value pairs that were not listed there would simply get removed.
    This would make it impossible for any other users of the
    external_id to have a reliable way of storing its data. One of
    such users could be the ovn-octavia-provider.
    
    Closes-Bug: #1896827
    Change-Id: Ie580534e4d91f1ca2e1dc8331632d49d4720e7ba


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1896827

Title:
  port update api should not lose foreign external_ids

Status in neutron:
  Fix Released

Bug description:
  Currently, the update_port api in networking_ovn does not seem to
  retain values in the external_ids that it may not know about.

  That is not proper behavior as external ids in the lsp may be
  storing data used by another entity in neutron, such as
  ovn-octavia-provider.

  Pseudo example:

  1- create neutron port (which creates lsp in ovn)
  2- add a new value to lsp's external_ids
  3- invoke neutron: port_update
  4- check an verify that after port update the key/value pair added in step 2 is still present

  Ref code to networking-ovn port_update:

  https://github.com/openstack/networking-
  ovn/blob/51e4351309c1f38c2ed353e6547c60ae9d5d50f5/networking_ovn/common/ovn_client.py#L456

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1896827/+subscriptions