yahoo-eng-team team mailing list archive

[OpenStack Infra <1897269@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/756278
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=612942bdf7b3d31349aeb3c408df6d5ae7446cba
Submitter: Zuul
Branch:    master

commit 612942bdf7b3d31349aeb3c408df6d5ae7446cba
Author: Walter Doekes <walter+github@xxxxxx>
Date:   Fri Sep 25 13:44:20 2020 +0200

    users: Correct lock_password status visibility (Yes/No) in user details
    
    Before this change, it would always say No, regardless of actual
    setting.
    
    Change-Id: Ib30d818ecae7b8edd33e94ad2c3c0e2ad8e01822
    Closes-Bug: #1897269


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1897269

Title:
  Locked password in user overview always shows "no" (False)

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Version: OpenStack Horizon stable/ussri (18.3.2-12-gc348787fa)

  ** Action **

  View user details in Horizon.

  ** Expected **

  "Locked password: <whatever was set>"

  ** Actual behaviour **

  "Locked password: no"

  ** Fix **

  https://github.com/ossobv/horizon/commit/f4a3bea22d3f8f71c5ad0da46945244c9f3b67f5
  ^- set lock_password in the Tab context instead of in the super-context

  Now it can be seen in the tab details:
  openstack_dashboard/dashboards/identity/users/templates/users/_detail_overview.html
  ```
      <dt>{% trans "Lock password" %}</dt>
      <dd>{{ lock_password|yesno:"yes,no"|capfirst }}</dd>
  ```

  Cheers,
  Walter Doekes
  OSSO B.V.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1897269/+subscriptions