yahoo-eng-team team mailing list archive

[OpenStack Infra <1904051@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/762543
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1d23b358d6b3ecef1561c196270243654618b005
Submitter: Zuul
Branch:    master

commit 1d23b358d6b3ecef1561c196270243654618b005
Author: Stephen Finucane <stephenfin@xxxxxxxxxx>
Date:   Thu Nov 12 11:45:20 2020 +0000

    functional: Wait for revert resize to complete
    
    When reverting a resize, we need to wait for the migration status to
    change to 'reverted', but we also need to wait for the relevant
    versioned notification to be emitted. The reason for this is noted in a
    couple of places, including the '_revert_resize' helper in the
    'nova.tests.functional.integrated_helpers.InstanceHelperMixin' module:
    
      [T]he migration status is changed to "reverted" in the dest host
      revert_resize method but the allocations are cleaned up in the source
      host finish_revert_resize method so we need to wait for the
      finish_revert_resize method to complete.
    
    Two tests in the 'test_cross_cell_migrate' test module were not doing
    this wait, resulting in intermittent failures in CI due to the races.
    Resolve this now.
    
    Change-Id: I3ec6cae19b362ac9cc311a979f680cf64db4f458
    Signed-off-by: Stephen Finucane <stephenfin@xxxxxxxxxx>
    Closes-Bug: #1904051


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1904051

Title:
  Intermittent failures in cross-cell functional tests

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Some functional tests are failing due to the following error:

      Captured traceback:
      ~~~~~~~~~~~~~~~~~~~
      Traceback (most recent call last):

        File "/home/zuul/src/opendev.org/openstack/nova/nova/tests/functional/test_cross_cell_migrate.py", line 1076, in test_resize_revert_from_stopped
      self.api.post_server_action(server['id'], {'migrate': None})

        File "/home/zuul/src/opendev.org/openstack/nova/nova/tests/functional/api/client.py", line 268, in post_server_action
      return self.api_post(

        File "/home/zuul/src/opendev.org/openstack/nova/nova/tests/functional/api/client.py", line 210, in api_post
      return APIResponse(self.api_request(relative_uri, **kwargs))

        File "/home/zuul/src/opendev.org/openstack/nova/nova/tests/functional/api/client.py", line 186, in api_request
      raise OpenStackApiException(

      nova.tests.functional.api.client.OpenStackApiException: Unexpected
  status code: {"conflictingRequest": {"code": 409, "message": "Cannot
  'migrate' instance 8841d71c-c29d-4dc8-9736-98dbc6ee221f while it is in
  task_state resize_reverting"}}

  This appears to be because we're not waiting for the resize-revert
  operation to fully complete before attempting other operations. We
  need to wait for the versioned notification emitted on the source
  compute, which occurs after the instance's task state has been
  updated, as opposed to simply waiting for the migration record to
  change status, which occurs before (and on the destination node).

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1904051/+subscriptions