yahoo-eng-team team mailing list archive

[OpenStack Infra <1903989@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/762515
Committed: https://opendev.org/openstack/neutron/commit/7cf52bb5325ac73b7afa3212cb84d29831e3724a
Submitter: Zuul
Branch:    master

commit 7cf52bb5325ac73b7afa3212cb84d29831e3724a
Author: Michal Arbet <michal.arbet@xxxxxxxxxx>
Date:   Thu Nov 12 13:43:24 2020 +0100

    Fix migration failed due TypeError of new_vlan_tag
    
    There could be a situation, when there are ports
    with port_tags None created in OS infra.
    
    Under normal circumstances, it would take some error
    to the log and go further.
    But only because there is a "new_vlan_tags must be string"
    in that log, it is throwing out typeError and dropping
    the execution of code and the migration is ending by code 500.
    
    And this is all done without a message from
    the log, which is extremely bad.
    
    This patch is fixing this behaviour, and flow
    goes on.
    
    Change-Id: Id4ba8d32e6b2301f25c12f83a0708b62aa5b9d6d
    Closes-Bug: #1903989


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1903989

Title:
  Bug in logging potentionally causing neutron to fail

Status in neutron:
  Fix Released

Bug description:
  Hi,

  Due to some completely different issue, we had ports with port_tags None created in production. Under normal circumstances, it would take some error to the log and go further.
  But only because there is a "new_vlan_tags must be string" in that log, it threw out typeError and dropped the execution of code and the migration ended by code 500.

  And without a message from the log, which is extremely bad.
  It was able to go through the repair of the logo

  2020-10-20 11:20:37.457 6 INFO
  neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent [req-
  b8df2b85-d523-4217-b62c-e17b4404cade - - - - -] Error formatting log
  line msg="Port '*(port_name)s' has lost its vlan tag '*(vlan_tag)d'!
  Current vlan tag on this port is '*(new_vlan_tag)d'."
  err=TypeError('*d format: a number is required, not list')

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1903989/+subscriptions