yahoo-eng-team team mailing list archive

[Brin Zhang <1908336@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Since microversion 2.77, allowed request body schema are {'unshelve':
null} or {'unshelve': {'availability_zone': <string>}}, and {'unshelve':
{}} request body is not allowed.

The reason that not allowed  to request {}: {} means allowed everything
or any unknown request body which is later ignored so confusing for
users. where {'unshelve': null} means allow only empty request body,
like for {}. i can pass {'unshelve': {'unknown': 'anything', ....}},
that's not security.

api-ref: https://docs.openstack.org/api-ref/compute/?expanded=unshelve-
restore-shelved-server-unshelve-action-detail,show-console-output-os-
getconsoleoutput-action-detail#unshelve-restore-shelved-server-unshelve-
action

** Affects: nova
     Importance: Low
     Assignee: Brin Zhang (zhangbailin)
         Status: New

** Changed in: nova
   Importance: Undecided => Low

** Changed in: nova
     Assignee: (unassigned) => Brin Zhang (zhangbailin)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1908336

Title:
  api-ref: Improve the description in unshleve server API

Status in OpenStack Compute (nova):
  New

Bug description:
  Since microversion 2.77, allowed request body schema are {'unshelve':
  null} or {'unshelve': {'availability_zone': <string>}}, and
  {'unshelve': {}} request body is not allowed.

  The reason that not allowed  to request {}: {} means allowed
  everything or any unknown request body which is later ignored so
  confusing for users. where {'unshelve': null} means allow only empty
  request body, like for {}. i can pass {'unshelve': {'unknown':
  'anything', ....}}, that's not security.

  api-ref: https://docs.openstack.org/api-ref/compute/?expanded
  =unshelve-restore-shelved-server-unshelve-action-detail,show-console-
  output-os-getconsoleoutput-action-detail#unshelve-restore-shelved-
  server-unshelve-action

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1908336/+subscriptions