yahoo-eng-team team mailing list archive

[Dan Watkins <1911227@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The test_seed_random_data test specifies this user-data:

#cloud-config
random_seed:
  data: 'MYUb34023nD:LFDK10913jk;dfnk:Df'
  encoding: raw
  file: /root/seed

and asserts that that is the exact content of /root/seed.  If we're
using a datasource which sets random_seed in its metadata (i.e. Azure
and OpenStack, at least), this test fails: cc_seed_random will _append_
the cloud's random_seed to the given data before writing it out.

To be clear, the bug here is that this is unexpected: we do not document
this behaviour.  I can't think of a compelling case for not behaving in
this way: more entropy is good, and we have write_files if users really
do want to write out exact content to a path.

The TestSeedRandomData.test_seed_random_data integration test assumes
the "exact writing" behaviour, so will also need to be updated.

** Affects: cloud-init
     Importance: Medium
     Assignee: Dan Watkins (oddbloke)
         Status: Triaged


** Tags: docs

** Changed in: cloud-init
       Status: New => Triaged

** Changed in: cloud-init
   Importance: Undecided => Medium

** Summary changed:

- cc_seed_random: unexpectedly appends cloud's random_seed to specified seed
+ cc_seed_random: unexpectedly appends cloud's random_seed to specified seed data

** Description changed:

  The test_seed_random_data test specifies this user-data:
  
  #cloud-config
  random_seed:
-   data: 'MYUb34023nD:LFDK10913jk;dfnk:Df'
-   encoding: raw
-   file: /root/seed
+   data: 'MYUb34023nD:LFDK10913jk;dfnk:Df'
+   encoding: raw
+   file: /root/seed
  
  and asserts that that is the exact content of /root/seed.  If we're
  using a datasource which sets random_seed in its metadata (i.e. Azure
  and OpenStack, at least), this test fails: cc_seed_random will _append_
  the cloud's random_seed to the given data before writing it out.
  
  To be clear, the bug here is that this is unexpected: we do not document
  this behaviour.  I can't think of a compelling case for not behaving in
  this way: more entropy is good, and we have write_files if users really
  do want to write out exact content to a path.
+ 
+ The TestSeedRandomData.test_seed_random_data integration test assumes
+ the "exact writing" behaviour, so will also need to be updated.

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to cloud-init.
https://bugs.launchpad.net/bugs/1911227

Title:
  cc_seed_random: unexpectedly appends cloud's random_seed to specified
  seed data

Status in cloud-init:
  Triaged

Bug description:
  The test_seed_random_data test specifies this user-data:

  #cloud-config
  random_seed:
    data: 'MYUb34023nD:LFDK10913jk;dfnk:Df'
    encoding: raw
    file: /root/seed

  and asserts that that is the exact content of /root/seed.  If we're
  using a datasource which sets random_seed in its metadata (i.e. Azure
  and OpenStack, at least), this test fails: cc_seed_random will
  _append_ the cloud's random_seed to the given data before writing it
  out.

  To be clear, the bug here is that this is unexpected: we do not
  document this behaviour.  I can't think of a compelling case for not
  behaving in this way: more entropy is good, and we have write_files if
  users really do want to write out exact content to a path.

  The TestSeedRandomData.test_seed_random_data integration test assumes
  the "exact writing" behaviour, so will also need to be updated.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-init/+bug/1911227/+subscriptions