yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #85394
[Bug 1918502] [NEW] Fault Injection #2001 - improve unit test effectiveness
Public bug reported:
Description
===========
I have performed fault injection in openstack nova by changing the code of compute/api.py (inserting a representative/probable bug) and then ran the unit, functional and integration tests and discover that some of the bugs inserted were not detected by the test suite:
The reference WVAE (Wrong arithmetic expression used in assignment) is a type of fault where the assignment of a variable using an expression is incorrect.
Steps to reproduce
==================
Line of Code |Original Code |Incorrect Code
1835 |algorithm = cipher.split('-')[0] if cipher else None |algorithm = None if cipher else cipher.split('-')[0]
Refactor the line of code above to the incorrect code. Then execute the unit tests.
Expected result
===============
The unit tests should detect the fault.
Actual result
===============
The fault was not detected by the unit tests.
Environment
===========
The code tested is on the stable/ussuri branch.
** Affects: nova
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1918502
Title:
Fault Injection #2001 - improve unit test effectiveness
Status in OpenStack Compute (nova):
New
Bug description:
Description
===========
I have performed fault injection in openstack nova by changing the code of compute/api.py (inserting a representative/probable bug) and then ran the unit, functional and integration tests and discover that some of the bugs inserted were not detected by the test suite:
The reference WVAE (Wrong arithmetic expression used in assignment) is a type of fault where the assignment of a variable using an expression is incorrect.
Steps to reproduce
==================
Line of Code |Original Code |Incorrect Code
1835 |algorithm = cipher.split('-')[0] if cipher else None |algorithm = None if cipher else cipher.split('-')[0]
Refactor the line of code above to the incorrect code. Then execute the unit tests.
Expected result
===============
The unit tests should detect the fault.
Actual result
===============
The fault was not detected by the unit tests.
Environment
===========
The code tested is on the stable/ussuri branch.
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1918502/+subscriptions
Follow ups