yahoo-eng-team team mailing list archive

[Henrique Marques <1918548@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Description
===========
I have performed fault injection in openstack nova by changing the code of compute/api.py (inserting a representative/probable bug) and then ran the unit, functional and integration tests and discover that some of the bugs inserted were not detected by the test suite:
The reference WLEC (Wrong logical expression used as branch condition) is a type of fault where a logical expression in a condition is incorrect.

Steps to reproduce
==================

Line of Code	|Original Code		|Incorrect Code
5568   |if must_be_up and not self.servicegroup_api.service_is_up(service):	   |if must_be_up or not self.servicegroup_api.service_is_up(service):

Refactor the line of code above to the incorrect code. Then execute the
unit tests.

Expected result
===============
The unit tests should detect the fault.

Actual result
===============
The fault was not detected by the unit tests.

Environment
===========
The code tested is on the stable/ussuri branch.

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1918548

Title:
  Fault Injection #593 - improve unit test effectiveness

Status in OpenStack Compute (nova):
  New

Bug description:
  Description
  ===========
  I have performed fault injection in openstack nova by changing the code of compute/api.py (inserting a representative/probable bug) and then ran the unit, functional and integration tests and discover that some of the bugs inserted were not detected by the test suite:
  The reference WLEC (Wrong logical expression used as branch condition) is a type of fault where a logical expression in a condition is incorrect.

  Steps to reproduce
  ==================

  Line of Code	|Original Code		|Incorrect Code
  5568   |if must_be_up and not self.servicegroup_api.service_is_up(service):	   |if must_be_up or not self.servicegroup_api.service_is_up(service):

  Refactor the line of code above to the incorrect code. Then execute
  the unit tests.

  Expected result
  ===============
  The unit tests should detect the fault.

  Actual result
  ===============
  The fault was not detected by the unit tests.

  Environment
  ===========
  The code tested is on the stable/ussuri branch.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1918548/+subscriptions