← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1918537] Re: Fault Injection #1447 - improve unit test effectiveness

 

Lets discuss the future of this bug in the first one
https://bugs.launchpad.net/nova/+bug/1918340

** Changed in: nova
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1918537

Title:
  Fault Injection #1447 - improve unit test effectiveness

Status in OpenStack Compute (nova):
  Invalid

Bug description:
  Description
  ===========
  I have performed fault injection in openstack nova by changing the code of compute/api.py (inserting a representative/probable bug) and then ran the unit, functional and integration tests and discover that some of the bugs inserted were not detected by the test suite:
  The reference MPFC (Missing paremeter in function call) is a type of fault where a parameter is missing in a function call. 

  Steps to reproduce
  ==================

  Line of Code	|Original Code		|Incorrect Code
  4749	|"bdms = [objects.BlockDeviceMapping.get_by_volume_id(
                  context, volume['id'], instance.uuid)]"	|"bdms = [objects.BlockDeviceMapping.get_by_volume_id(
                  context, volume['id'])]"

  
  Refactor the line of code above to the incorrect code. Then execute the unit tests.

  Expected result
  ===============
  The unit tests should detect the fault.

  
  Actual result
  ===============
  The fault was not detected by the unit tests.

  Environment
  ===========
  The code tested is on the stable/ussuri branch.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1918537/+subscriptions


References