← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1552614] Re: Add enable_dhcp filter in get_network_info rpc

 

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/289165
Committed: https://opendev.org/openstack/neutron/commit/1483b63ffaf933903abf7317b03a99195a71c98a
Submitter: "Zuul (22348)"
Branch:    master

commit 1483b63ffaf933903abf7317b03a99195a71c98a
Author: Nurmatov Mamatisa <nurmatov.mamatisa@xxxxxxxxxx>
Date:   Thu Apr 8 18:48:29 2021 +0300

    Add enable_dhcp filter in get_network_info rpc
    
    Add enable_dhcp, to make a filter to avoid unnecessary
    net_info data transfer through rpc.
    
    Change-Id: Ibcef366f5b1f4b7da4f47f1f538a17111da0faa1
    Closes-Bug: #1552614


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1552614

Title:
  Add enable_dhcp filter in get_network_info rpc

Status in neutron:
  Fix Released

Bug description:
  As code in 
  https://github.com/openstack/neutron/blob/master/neutron/api/rpc/handlers/dhcp_rpc.py#L163

  the rpc get_active_network called by dhcp-agent to fetch network info,
  and subnet which enable_dhcp = False is not needed.

  It would better add 'enable_dhcp=True' into filter and recheck in dhcp
  agent would not need.

  https://github.com/openstack/neutron/blob/master/neutron/agent/linux/dhcp.py#L344

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1552614/+subscriptions


References