yahoo-eng-team team mailing list archive

[OpenStack Infra <1928007@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/nova/+/790511
Committed: https://opendev.org/openstack/nova/commit/8b647f1b3f56879be221b3925570790a1e0e77f8
Submitter: "Zuul (22348)"
Branch:    master

commit 8b647f1b3f56879be221b3925570790a1e0e77f8
Author: melanie witt <melwittt@xxxxxxxxx>
Date:   Mon May 10 17:31:25 2021 +0000

    rbd: Get rbd_utils unit tests running again
    
    Awhile back, change I25baf5edd25d9e551686b7ed317a63fd778be533 moved
    rbd_utils out from the libvirt driver and into a central location under
    nova/storage. This move missed adding a __init__.py file under
    nova/tests/unit/storage, so unit test discovery wasn't picking up the
    rbd_utils tests and couldn't run them.
    
    This adds a __init__.py file under nova/tests/unit/storage to get the
    tests running again.
    
    This also fixes a small bug introduced by change
    I3032bbe6bd2d6acc9ba0f0cac4d00ed4b4464ceb in RbdTestCase.setUp() that
    passed nonexistent self.images_rbd_pool to self.flags. It should be
    self.rbd_pool.
    
    Closes-Bug: #1928007
    
    Change-Id: Ic03a5336abdced883f62f395690c0feac12075c8


** Changed in: nova
       Status: In Progress => Fix Released

** Changed in: nova/wallaby
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1928007

Title:
  rbd_utils unit tests not running in gate

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) victoria series:
  New
Status in OpenStack Compute (nova) wallaby series:
  In Progress

Bug description:
  Awhile back, change:

  https://review.opendev.org/c/openstack/nova/+/746904

  moved rbd_utils out from the libvirt driver and into a central
  location under nova/storage. This move missed adding a __init__.py
  file under nova/tests/unit/storage, so unit test discovery wasn't
  picking up the rbd_utils tests and couldn't run them.

  There was also a small bug introduced by change:

  https://review.opendev.org/c/openstack/nova/+/574301

  in RbdTestCase.setUp() that passed nonexistent self.images_rbd_pool to
  self.flags. It should be self.rbd_pool.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1928007/+subscriptions