yahoo-eng-team team mailing list archive

[OpenStack Infra <1929676@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/795979
Committed: https://opendev.org/openstack/neutron/commit/bc82a664b637c72b49fd585a41350164103d6aaa
Submitter: "Zuul (22348)"
Branch:    master

commit bc82a664b637c72b49fd585a41350164103d6aaa
Author: Slawek Kaplonski <skaplons@xxxxxxxxxx>
Date:   Fri Jun 11 12:12:07 2021 +0200

    Move dns-integration extension to the ML2_SUPPORTED_API_EXTENSIONS list
    
    dns-integration extension is actually implemented as ML2 extension
    driver, so has nothing to do with the L3 plugin.
    In OVN it was listed in the ML2_SUPPORTED_API_EXTENSIONS_OVN_L3 but it
    should be in ML2_SUPPORTED_API_EXTENSIONS. This patch moves it to the
    correct list.
    This patch also removes disable_dns_extension_by_extension_drivers
    method from the OVN L3 plugin class as there is no need to disable this
    extension by L3 agent.
    
    Related-Bug: #1929676
    Change-Id: I456afcc9054627e74b18460d169052f262451c22


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1929676

Title:
  API extensions not supported by e.g. OVN driver may still be on the
  list returned from neutron

Status in neutron:
  Fix Released

Bug description:
  Some time ago we introduced possibility for mechanism drivers to
  explicitly filter and filter API extensions which they don't supports
  so such extensions aren't really listed in the API.

  But the problem is that when there are more than one mech drivers
  enabled, first of them will filter some extensions, but other don't
  filters anything, not supported extensions may appears on the list.

  To reproduce the issue let's enable ovn and logging mech_drivers:

  mechanism_drivers = ovn,logger

  And then check e.g. dhcp_agent_scheduler that it will be on the list
  returned by cmd "neutron ext-list", even if it's not supported by ovn.

  The problem is that _filter_extensions_by_mech_driver is passing list
  of all ML2 extensions to each mech_driver so even if one of them
  disable it, other can add it back to the list:
  https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/plugin.py#L318

  Maybe better approach would be to have on the list only extensions
  which are supported by all enabled mech_drivers?

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1929676/+subscriptions