yahoo-eng-team team mailing list archive

[OpenStack Infra <1936675@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/801076
Committed: https://opendev.org/openstack/neutron/commit/923284fc3791949d93d7ded9820a44f98fc734b8
Submitter: "Zuul (22348)"
Branch:    master

commit 923284fc3791949d93d7ded9820a44f98fc734b8
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Fri Jul 16 14:55:55 2021 +0000

    Use explicit select condition in SQL query in "_port_filter_hook"
    
    Instead of executing a subquery inside a select, use a proper filter
    condition instead.
    
    Closes-Bug: #1936675
    Change-Id: I97e9ca244c0716510fcd4ec81d54046be9c5f8f8


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1936675

Title:
  Do not coerce a subquery into a select, create a proper select
  condition

Status in neutron:
  Fix Released

Bug description:
  When executing the UTs, we can see the following error:

      /opt/stack/neutron/neutron/db/db_base_plugin_v2.py:114: SAWarning: Coercing Subquery object into a select() for use in IN(); please pass a select() construct explicitly                                             
    conditions |= (models_v2.Port.network_id.in_(

  This is happening in method [1].

  [1]https://github.com/openstack/neutron/blob/d20b8708bc03fa0dfe45656b48408b3f74a67709/neutron/db/db_base_plugin_v2.py#L111-L118

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1936675/+subscriptions