← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1938093] [NEW] Inconsistent return code for "Feature not implemented' API

 

Public bug reported:

There is inconsistency on return code nova API return for  "Feature not
implemented'. Current return code are 400, 409, and 403.

- 400 case: Example: Multiattach Swap Volume Not Supported:
https://github.com/openstack/nova/blob/0c64f4c3eae8e2654ec11f60682c0fa5eda30c1a/nova/exception.py#L295
https://github.com/openstack/nova/blob/788035add9b32fa841389d906a0e307c231456ba/nova/api/openstack/compute/volumes.py#L429

- 403 case: Cyborg integration.
https://github.com/openstack/nova/blob/0c64f4c3eae8e2654ec11f60682c0fa5eda30c1a/nova/exception.py#L158
https://github.com/openstack/nova/blob/0e7cd9d1a95a30455e3c91916ece590454235e0e/nova/api/openstack/compute/suspend_server.py#L47

- 409 case: Example: Operation Not Supported For SEV , Operation Not Supported For VTPM
https://github.com/openstack/nova/blob/0c64f4c3eae8e2654ec11f60682c0fa5eda30c1a/nova/exception.py#L528-L537

In xena PTG, we agreed to fix this by returning 400 in all cases and
backport the fix. L446: https://etherpad.opendev.org/p/nova-xena-ptg

** Affects: nova
     Importance: Undecided
     Assignee: Ghanshyam Mann (ghanshyammann)
         Status: Triaged


** Tags: api

** Changed in: nova
       Status: New => Triaged

** Changed in: nova
     Assignee: (unassigned) => Ghanshyam Mann (ghanshyammann)

** Tags added: api

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1938093

Title:
  Inconsistent return code for "Feature not implemented' API

Status in OpenStack Compute (nova):
  Triaged

Bug description:
  There is inconsistency on return code nova API return for  "Feature
  not implemented'. Current return code are 400, 409, and 403.

  - 400 case: Example: Multiattach Swap Volume Not Supported:
  https://github.com/openstack/nova/blob/0c64f4c3eae8e2654ec11f60682c0fa5eda30c1a/nova/exception.py#L295
  https://github.com/openstack/nova/blob/788035add9b32fa841389d906a0e307c231456ba/nova/api/openstack/compute/volumes.py#L429

  - 403 case: Cyborg integration.
  https://github.com/openstack/nova/blob/0c64f4c3eae8e2654ec11f60682c0fa5eda30c1a/nova/exception.py#L158
  https://github.com/openstack/nova/blob/0e7cd9d1a95a30455e3c91916ece590454235e0e/nova/api/openstack/compute/suspend_server.py#L47

  - 409 case: Example: Operation Not Supported For SEV , Operation Not Supported For VTPM
  https://github.com/openstack/nova/blob/0c64f4c3eae8e2654ec11f60682c0fa5eda30c1a/nova/exception.py#L528-L537

  In xena PTG, we agreed to fix this by returning 400 in all cases and
  backport the fix. L446: https://etherpad.opendev.org/p/nova-xena-ptg

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1938093/+subscriptions



Follow ups