← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1934930] Re: [ovn] Multiple servers can try to create neutron_pg_drop at the same time

 

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/799900
Committed: https://opendev.org/openstack/neutron/commit/2e6f6c9ec30259d03363479e72e36129b08563b1
Submitter: "Zuul (22348)"
Branch:    master

commit 2e6f6c9ec30259d03363479e72e36129b08563b1
Author: Terry Wilson <twilson@xxxxxxxxxx>
Date:   Wed Jul 7 18:21:47 2021 +0000

    Ensure only one worker creates neturon_pg_drop
    
    Use an OVSDB lock to ensure that only one worker tries to create
    the neutron_pg_drop port group. This also waits pre_fork so that if
    getting the port group fails, neutron exits instead of continuing
    on without the port group being created.
    
    It was previously possible that a server could create the port
    group and we wouldn't get the update before trying to create it
    ourselves and checking for its existence.
    
    This also modifies the get_port_group method to use the built-in
    lookup() which searches by name or uuid and can take advantage of
    both indexing and newly added ovsdbapp wait for sync functionality.
    
    Closes-Bug: #1934930
    Change-Id: Id870f746ff8e9741a7c211aebdcf13597d31465b


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1934930

Title:
  [ovn] Multiple servers can try to create neutron_pg_drop at the same
  time

Status in neutron:
  Fix Released

Bug description:
  Even though we use may_exist=True to create the neutron_pg_drop
  Port_Group, it's possible that when another server creates it before
  us that we don't get the update before we check if it exists before
  exiting.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1934930/+subscriptions



References