← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1938569] Re: Typo in OVN SUPPORTED_DHCP_OPTS_MAPPING dictionary

 

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/803037
Committed: https://opendev.org/openstack/neutron/commit/d4b1b4a0729c187551e1fa2b2855db136456d496
Submitter: "Zuul (22348)"
Branch:    master

commit d4b1b4a0729c187551e1fa2b2855db136456d496
Author: Eduardo Olivares <eolivare@xxxxxxxxxx>
Date:   Fri Jul 30 15:49:06 2021 +0200

    Fix typo in OVN SUPPORTED_DHCP_OPTS_MAPPING dictionary (ia-addr)
    
    Closes-Bug: #1938569
    
    Change-Id: I10e0834594f68e06244c393c00d0b3d840c45fc5


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1938569

Title:
  Typo in OVN SUPPORTED_DHCP_OPTS_MAPPING dictionary

Status in neutron:
  Fix Released

Bug description:
  SUPPORTED_DHCP_OPTS_MAPPING is a dictionary that maps neutron dhcp-
  option names to ovn dhcp-option names. OVN dhcp-option ia_addr
  corresponds with neutron dhcp-option names 'ia-addr' or '5'. However,
  there is a type here and the corresponding OVN value is defined as
  ip_addr instead of ia_addr [1]

  Definition of ia_addr from OVN code: [2]

  The following openstack command created a wrong entry in the OVN NBDB DHCP_OPTIONS
  $ openstack port create --network tempest-DHCPTest-980691237 --extra-dhcp-option name=ia-addr,value=2001::2001,ip-version=6  port-test-202

  
  # ovn-nbctl list dhcp_options c9b0f6c0-c1bf-4e91-9e66-5e75491ae9e5
  _uuid               : c9b0f6c0-c1bf-4e91-9e66-5e75491ae9e5
  cidr                : "2001:db8::/64"
  external_ids        : {"neutron:revision_number"="0", port_id="1188bca5-4b75-4810-a9a0-38ecc96d0274", subnet_id="567272f0-f1b8-423c-a939-9dea6b5e26ab"}
  options             : {dhcpv6_stateless="true", ip_addr="2001::2001", server_id="fa:16:3e:ce:f4:67"}



  
  [1] https://opendev.org/openstack/neutron/src/commit/19372a3cd8b4e6e45f707753b914e133857dd629/neutron/common/ovn/constants.py#L163
  [2] https://github.com/ovn-org/ovn/blob/1c9e46ab5c05043a8cd6c47b5fec2e1ac4c962db/lib/ovn-l7.h#L261

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1938569/+subscriptions



References