yahoo-eng-team team mailing list archive

[Jason Anderson <1942469@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Change I07c70db027f2ae03ffb5a95072e019e8a5fdc411 made it so
PRECOMMIT_DELETE and AFTER_DELETE both receive the network dict fetched
from the DB (decorated with any resource_extend hooks). However, this
network representation does not include segment information like
segmentation_id or network_type.

The networking-generic-switch ML2 plugin assumes that such information
is present on the delete postcommit hook and needs it to do its job:
https://opendev.org/openstack/networking-generic-
switch/src/branch/master/networking_generic_switch/generic_switch_mech.py#L164-L166

As a result networking-generic-switch cannot currently be deployed.

Example error:

```
2021-09-02 12:27:57.438 30 ERROR neutron.plugins.ml2.managers [req-99b0b44f-171d-41a3-b99d-1cccb27b3006 bcb7ef06be674b9199b36e8f18b546f3 570aad8999f7499db99eae22fe9b29bb - default default] Mechanism driver 'genericswitch' failed in delete_network_postcommit: KeyError: 'provider:network_type'
2021-09-02 12:27:57.438 30 ERROR neutron.plugins.ml2.managers Traceback (most recent call last):
2021-09-02 12:27:57.438 30 ERROR neutron.plugins.ml2.managers   File "/var/lib/kolla/venv/lib/python2.7/site-packages/neutron/plugins/ml2/managers.py", line 479, in _call_on_drivers
2021-09-02 12:27:57.438 30 ERROR neutron.plugins.ml2.managers     getattr(driver.obj, method_name)(context)
2021-09-02 12:27:57.438 30 ERROR neutron.plugins.ml2.managers   File "/var/lib/kolla/venv/lib/python2.7/site-packages/networking_generic_switch/generic_switch_mech.py", line 315, in delete_network_postcommit
2021-09-02 12:27:57.438 30 ERROR neutron.plugins.ml2.managers     provider_type = network['provider:network_type']
2021-09-02 12:27:57.438 30 ERROR neutron.plugins.ml2.managers KeyError: 'provider:network_type'
2021-09-02 12:27:57.438 30 ERROR neutron.plugins.ml2.managers
2021-09-02 12:27:57.440 30 ERROR neutron.plugins.ml2.plugin [req-99b0b44f-171d-41a3-b99d-1cccb27b3006 bcb7ef06be674b9199b36e8f18b546f3 570aad8999f7499db99eae22fe9b29bb - default default] mechanism_manager.delete_network_postcommit failed: MechanismDriverError
```

** Affects: neutron
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1942469

Title:
  Network delete notifications no longer container segment info

Status in neutron:
  New

Bug description:
  Change I07c70db027f2ae03ffb5a95072e019e8a5fdc411 made it so
  PRECOMMIT_DELETE and AFTER_DELETE both receive the network dict
  fetched from the DB (decorated with any resource_extend hooks).
  However, this network representation does not include segment
  information like segmentation_id or network_type.

  The networking-generic-switch ML2 plugin assumes that such information
  is present on the delete postcommit hook and needs it to do its job:
  https://opendev.org/openstack/networking-generic-
  switch/src/branch/master/networking_generic_switch/generic_switch_mech.py#L164-L166

  As a result networking-generic-switch cannot currently be deployed.

  Example error:

  ```
  2021-09-02 12:27:57.438 30 ERROR neutron.plugins.ml2.managers [req-99b0b44f-171d-41a3-b99d-1cccb27b3006 bcb7ef06be674b9199b36e8f18b546f3 570aad8999f7499db99eae22fe9b29bb - default default] Mechanism driver 'genericswitch' failed in delete_network_postcommit: KeyError: 'provider:network_type'
  2021-09-02 12:27:57.438 30 ERROR neutron.plugins.ml2.managers Traceback (most recent call last):
  2021-09-02 12:27:57.438 30 ERROR neutron.plugins.ml2.managers   File "/var/lib/kolla/venv/lib/python2.7/site-packages/neutron/plugins/ml2/managers.py", line 479, in _call_on_drivers
  2021-09-02 12:27:57.438 30 ERROR neutron.plugins.ml2.managers     getattr(driver.obj, method_name)(context)
  2021-09-02 12:27:57.438 30 ERROR neutron.plugins.ml2.managers   File "/var/lib/kolla/venv/lib/python2.7/site-packages/networking_generic_switch/generic_switch_mech.py", line 315, in delete_network_postcommit
  2021-09-02 12:27:57.438 30 ERROR neutron.plugins.ml2.managers     provider_type = network['provider:network_type']
  2021-09-02 12:27:57.438 30 ERROR neutron.plugins.ml2.managers KeyError: 'provider:network_type'
  2021-09-02 12:27:57.438 30 ERROR neutron.plugins.ml2.managers
  2021-09-02 12:27:57.440 30 ERROR neutron.plugins.ml2.plugin [req-99b0b44f-171d-41a3-b99d-1cccb27b3006 bcb7ef06be674b9199b36e8f18b546f3 570aad8999f7499db99eae22fe9b29bb - default default] mechanism_manager.delete_network_postcommit failed: MechanismDriverError
  ```

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1942469/+subscriptions