yahoo-eng-team team mailing list archive

[Spencer Butler <1954789@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Please ensure all variable values are double quoted in "etc/rc.conf".

While rc.conf(5) does not explicitly call for the use of single or
double quotes in ${rc_conf_files}, "etc/defaults/rc.conf" does.
rc.conf(5) does, in fact, use double quotes '"' in all of it's examples.
It is best practice to keep "etc/rc.conf" neat and tidy with the use of
double quotes around all variable values.

The bsd_utils.py (https://github.com/canonical/cloud-
init/blob/main/cloudinit/distros/bsd_utils.py#L15) script has a
"_unquote" function, that seems counterintuitive to the formatting of
this file.

## etc/defaults/rc.conf
<snip>
# All arguments must be in double or single quotes.
#
# For a more detailed explanation of all the rc.conf variables, please
# refer to the rc.conf(5) manual page.
<snip>

## etc/rc.conf with a mix of quotes and no quotes, as applied by cloud-init
$ cat /etc/rc.conf
sshd_enable="YES"
cloudinit_enable="YES"
qemu_guest_agent_enable="YES"
qemu_guest_agent_flags="-d -v -l /var/log/qemu-ga.log"
ntpdate_enable="YES"
ntpdate_flags="ntp.domain.net"
ntpd_enable="YES"
ifconfig_vtnet0_name=eth0
defaultrouter=1.2.3.1
ifconfig_eth0='1.2.3.4 netmask 255.255.255.0'
hostname=freebsd13-short.localdomain

** Affects: cloud-init
     Importance: Undecided
         Status: New


** Tags: freebsd rc.conf

** Attachment added: "cloud-init logs"
   https://bugs.launchpad.net/bugs/1954789/+attachment/5547572/+files/cloud-init.tar.gz

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to cloud-init.
https://bugs.launchpad.net/bugs/1954789

Title:
  FreeBSD - double quotes for rc.conf

Status in cloud-init:
  New

Bug description:
  Please ensure all variable values are double quoted in "etc/rc.conf".

  While rc.conf(5) does not explicitly call for the use of single or
  double quotes in ${rc_conf_files}, "etc/defaults/rc.conf" does.
  rc.conf(5) does, in fact, use double quotes '"' in all of it's
  examples. It is best practice to keep "etc/rc.conf" neat and tidy with
  the use of double quotes around all variable values.

  The bsd_utils.py (https://github.com/canonical/cloud-
  init/blob/main/cloudinit/distros/bsd_utils.py#L15) script has a
  "_unquote" function, that seems counterintuitive to the formatting of
  this file.

  ## etc/defaults/rc.conf
  <snip>
  # All arguments must be in double or single quotes.
  #
  # For a more detailed explanation of all the rc.conf variables, please
  # refer to the rc.conf(5) manual page.
  <snip>

  ## etc/rc.conf with a mix of quotes and no quotes, as applied by cloud-init
  $ cat /etc/rc.conf
  sshd_enable="YES"
  cloudinit_enable="YES"
  qemu_guest_agent_enable="YES"
  qemu_guest_agent_flags="-d -v -l /var/log/qemu-ga.log"
  ntpdate_enable="YES"
  ntpdate_flags="ntp.domain.net"
  ntpd_enable="YES"
  ifconfig_vtnet0_name=eth0
  defaultrouter=1.2.3.1
  ifconfig_eth0='1.2.3.4 netmask 255.255.255.0'
  hostname=freebsd13-short.localdomain

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-init/+bug/1954789/+subscriptions