yahoo-eng-team team mailing list archive

[OpenStack Infra <1810963@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/818933
Committed: https://opendev.org/openstack/neutron-tempest-plugin/commit/e01cd53d6c6cd9d74ead277c1fcd5eba73625397
Submitter: "Zuul (22348)"
Branch:    master

commit e01cd53d6c6cd9d74ead277c1fcd5eba73625397
Author: Mitya_Eremeev <mitossvyaz@xxxxxxx>
Date:   Tue Nov 23 17:47:21 2021 +0300

    Set SG quota for specific project.
    
    project_id was initialized too early.
    It was None. The same for tenant_id.
    That's why unlimited SG quota was set for
    "some default project".
    But the project in test had default quota(10).
    If test class created more 10 SG then arised exception
    "OverQuota".
    Also SG quota for default project was reset to default value in cleanup.
    It could harm another tests which were launched in parallel.
    
    Closes-Bug: 1895876
    Closes-Bug: 1810963
    Change-Id: If7f3789b2791be08088588619f3a1629aeecbda4


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1810963

Title:
  Neutron Tempest plugin creates new users/projects even if
  use_dynamic_credentials is set to False

Status in neutron:
  Fix Released

Bug description:
  Hello together.

  I run Neutron tempest test plugin and have some test cases which fail because of OverQuota errors. 
  The reason is that the limits/quota for new users/projects is 0 in my environment. Thus, OverQuota is raised. If neutron tempest plugin would care about the use_dynamic_credentials = False then OverQuota would not be raised because it would use my configured users/projects below with high Quota.
  Other suggestion: if isolated tenant is really necessary for a certain test then this test should be skipped if use_dynamic_credentials = False but force_tenant_isolation = True is required.

  I configured tempest with 3 users and corresponding projects to
  perform the tests:

  - username: 'tempestuser1'
    password: MYSUPERSECRETPASSWORD
    tenant_name: 'tempest1'
    project_name: 'tempest1'
  - username: 'tempestuser2'
    password: MYSUPERSECRETPASSWORD
    tenant_name: 'tempest2'
    project_name: 'tempest2'
  - username: 'admin'
    password: MYSUPERSECRETPASSWORD
    tenant_name: 'admin'
    project_name: 'admin'
    types:
    - admin

  I was able to debug the test run and found some code which overwrite
  use_dynamic_credentials = False:

  https://github.com/openstack/neutron-tempest-
  plugin/blob/06ef854082cb1f62038167e7e654181aa8727369/neutron_tempest_plugin/api/base.py#L1022

  https://github.com/openstack/neutron-tempest-
  plugin/blob/06ef854082cb1f62038167e7e654181aa8727369/neutron_tempest_plugin/api/test_auto_allocated_topology.py#L33

  https://github.com/openstack/neutron-tempest-
  plugin/blob/06ef854082cb1f62038167e7e654181aa8727369/neutron_tempest_plugin/api/test_qos.py#L603

  https://github.com/openstack/neutron-tempest-
  plugin/blob/06ef854082cb1f62038167e7e654181aa8727369/neutron_tempest_plugin/api/admin/test_floating_ips_admin_actions.py#L28

  https://github.com/openstack/neutron-tempest-
  plugin/blob/06ef854082cb1f62038167e7e654181aa8727369/neutron_tempest_plugin/api/admin/test_shared_network_extension.py#L177

  above code forces to use dynamic_credentials because of:

  https://github.com/openstack/tempest/blob/7e4087fb104bc3ac9608c524f2b7c875205ccbbb/tempest/common/credentials_factory.py#L137

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1810963/+subscriptions