yahoo-eng-team team mailing list archive

[OpenStack Infra <1955121@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/822098
Committed: https://opendev.org/openstack/neutron/commit/6809bed632b1c155bf370b78353e6b0fe059b3f0
Submitter: "Zuul (22348)"
Branch:    master

commit 6809bed632b1c155bf370b78353e6b0fe059b3f0
Author: Slawek Kaplonski <skaplons@xxxxxxxxxx>
Date:   Fri Dec 17 12:34:07 2021 +0100

    Don't fail subnet validation if gw_ip is actually not changed
    
    In subnet update API call Neutron checks if gateway_ip was send to be
    updated and if so, it checkes if old gateway_ip isn't already allocated
    to some router port. If it's already used, Neutron returns 409 response.
    This is valid behaviour but sometimes, some automation tools may do
    subnet update request and pass the same gateway ip as already used by
    the subnet. In such case, as gateway_ip is actually not changed Neutron
    should not raise exception in that validation.
    
    Closes-Bug: #1955121
    Change-Id: Iba90b44331fdc63273fd3d19c583a24b5295c0ac


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1955121

Title:
  Update subnet with same gateway_ip as is already used should be
  allowed

Status in neutron:
  Fix Released

Bug description:
  During subnet update neutron validates, if gateway_ip is passed in the PUT request and if it is, validates if old gateway_ip isn't already allocated to some router's port. If it is, Neutron will forbid to update subnet.
  That's totally valid behavior but in case when "new" gateway_ip is actually the same as old one Neutron should not raise exception and allow to update subnet.
  It may be useful for example for some automation tools, like Heat and Tripleo which will not need to have additional logic to check if gateway_ip is actually changed or not and if it should be eventually cleaned manually.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1955121/+subscriptions