yahoo-eng-team team mailing list archive

[OpenStack Infra <1958075@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/nova/+/824830
Committed: https://opendev.org/openstack/nova/commit/33bc5c09f576680d150435fb7ad435b23e778316
Submitter: "Zuul (22348)"
Branch:    master

commit 33bc5c09f576680d150435fb7ad435b23e778316
Author: Takashi Kajinami <tkajinam@xxxxxxxxxx>
Date:   Sun Jan 16 23:30:41 2022 +0900

    Add fixtures to requirements
    
    The commit 887c445a7a6a17b92a37b6ed1dcdcc7dd009f65d made the nova.utils
    module dependent on the fixtures library but the change missed updating
    requirements and the fixtures library is not installed automatically.
    
    This change migrates the fixtures library from test-requirements.txt to
    requirements.txt so that the library is installed without test codes.
    
    Closes-Bug: #1958075
    Change-Id: I712f88fc1b6053fe6d1f13e708f3bd8874452a8f


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1958075

Title:
  The fixtures library is missing from requirements.txt

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Description
  ===========
  The following change[1] made the nova.utils module depend on the fixtures library.
  [1] https://review.opendev.org/c/openstack/nova/+/824280

  However the fixtures library is listed only in test-requirements.txt and is not yet listed in requirements.txt .
  Because of this the library is not installed in normal deployment and the `nova-manage api_db sync` command fails with the following error.

  Traceback (most recent call last):
    File "/usr/bin/nova-manage", line 6, in <module>
      from nova.cmd.manage import main
    File "/usr/lib/python3.6/site-packages/nova/cmd/manage.py", line 49, in <module>
      from nova.cmd import common as cmd_common
    File "/usr/lib/python3.6/site-packages/nova/cmd/common.py", line 26, in <module>
      import nova.db.main.api
    File "/usr/lib/python3.6/site-packages/nova/db/main/api.py", line 45, in <module>
      from nova import block_device
    File "/usr/lib/python3.6/site-packages/nova/block_device.py", line 26, in <module>
      from nova import utils
    File "/usr/lib/python3.6/site-packages/nova/utils.py", line 32, in <module>
      import fixtures
  ModuleNotFoundError: No module named 'fixtures'

  This issue was initially detected in litmus jobs in puppet repos[2].
  These jobs uses rdo packages which define dependencies based on requirements.txt

  [2] example:
  https://zuul.opendev.org/t/openstack/build/e086ca3375714860ae463b7a1d9b1bab

  Steps to reproduce
  ==================

  Expected result
  ===============

  Actual result
  =============

  Environment
  ===========

  Logs & Configs
  ==============

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1958075/+subscriptions