← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1959732] [NEW] import_key_pair missing quota recheck

 

Public bug reported:

When quotas were rearchitected back in Pike, a recheck mechanism was
added to handle racing parallel requests in order to enforce strict
quota limits. However, when quotas for key pairs were converted [1],
rechecking for quota was missed in import_key_pair. Quota recheck was
added only to create_key_pair.

This is a very latent bug and it could be debated whether quota
rechecking is useful enough, considering that quota limits on resources
like key pairs were meant primarily to defend against denial of service
attacks which try to fill up the database.

[1]
https://github.com/openstack/nova/commit/d247e361827b81708e8b9f3fe4512352ac76f9c8

** Affects: nova
     Importance: Low
         Status: Triaged


** Tags: quotas

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1959732

Title:
  import_key_pair missing quota recheck

Status in OpenStack Compute (nova):
  Triaged

Bug description:
  When quotas were rearchitected back in Pike, a recheck mechanism was
  added to handle racing parallel requests in order to enforce strict
  quota limits. However, when quotas for key pairs were converted [1],
  rechecking for quota was missed in import_key_pair. Quota recheck was
  added only to create_key_pair.

  This is a very latent bug and it could be debated whether quota
  rechecking is useful enough, considering that quota limits on
  resources like key pairs were meant primarily to defend against denial
  of service attacks which try to fill up the database.

  [1]
  https://github.com/openstack/nova/commit/d247e361827b81708e8b9f3fe4512352ac76f9c8

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1959732/+subscriptions