← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1951569] Re: [L3] L3 agent extension should always inherit from "L3AgentExtension"

 

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/818540
Committed: https://opendev.org/openstack/neutron/commit/ebca47365c261b881d0c0e0135821ce03471a336
Submitter: "Zuul (22348)"
Branch:    master

commit ebca47365c261b881d0c0e0135821ce03471a336
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Fri Nov 19 11:45:15 2021 +0000

    "L3AgentExtensionsManager" check loaded extensions
    
    Now "L3AgentExtensionsManager" lists loaded extension, checking if
    they inherit from "neutron_lib.agent.l3_extension.L3AgentExtension".
    If any extension does not, the L3 agent raises an exception and exits.
    
    Closes-Bug: #1951569
    Change-Id: I3ce4858cef9b3a3d7eab005dd1ad2bb3b5ef6ef3


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1951569

Title:
  [L3] L3 agent extension should always inherit from "L3AgentExtension"

Status in neutron:
  Fix Released

Bug description:
  All L3 agent extensions should inherit from
  "neutron_lib.agent.l3_extension.L3AgentExtension". The
  "L3AgentExtensionsManager" should check, just after the extension
  initialization, if the loaded extensions inherit from this API. If
  not, the extension will raise an exception and exit.

  Once this check is done, all methods ("add_router", "update_router",
  "delete_router" and "ha_state_change") can directly call the extension
  function without checking the presence or not of the related function.
  That is ensured by making all extension inherit by the defined API
  (located in neutron-lib and available for any project).

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1951569/+subscriptions



References