← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1952112] Re: Template topology page doesn't handle session expiration

 

Reviewed:  https://review.opendev.org/c/openstack/horizon/+/819124
Committed: https://opendev.org/openstack/horizon/commit/0bba95f190594120c21b8aac1852f113eb902ea6
Submitter: "Zuul (22348)"
Branch:    master

commit 0bba95f190594120c21b8aac1852f113eb902ea6
Author: Vadym Markov <vmarkov@xxxxxxxxxxxx>
Date:   Wed Nov 24 17:18:41 2021 +0200

    Make stack template page handle session expiration
    
    Currently, stack template diagram ignores user session timeout and
    silently tries to update diagram data getting 401 response for the every
    request. Proposed patch redirects to logout if Heat API returns 401 or 403
    
    Closes-Bug: #1952112
    Change-Id: I5a389e5fd04ff07cd0821712a56a319e21d91891


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1952112

Title:
  Template topology page doesn't handle session expiration

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Reproduced on master, but any release since about Pike seems to be
  affected.

  Steps to reproduce:
  1. Deploy any Openstack environment with Heat and heat-dashboard components enabled. Devstack should be enough
  2. Create any stack. "Most basic template" from https://docs.openstack.org/heat/victoria/template_guide/hot_guide.html should work well after passing valid image name
  3. Go to Project->Orchestration->Stacks->created stack->Topology tab
  4. Wait until session timeout (1 hour by default) or mangle sessionid cookie value in browser to make it invalid

  Actual behavior:
  Visually nothing changed, but repeating requests to <hostname>/project/stacks/get_d3_data/<stack_id> return 401. Server-side logs are also affected.

  Expected behavior:
  Some form of logout or notification about expired user session

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1952112/+subscriptions



References