← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1962844] [NEW] [SR-IOV] QoS extension doesn't set max-tx-rate and min-tx-rate in the same port

 

Public bug reported:

The SR-IOV agent extension can handle max-BW and min-BW QoS rules, but
currently doesn't apply both to the same port at the same time.

The problem is how the Pyroute2 command is used. The "ip link" command allows to set "rate" and "min" rules in two independent commands. E.g.:
$ ip link set dev enp196s0f0 vf 5 rate 30
$ ip l show dev enp196s0f0
  vf 5     link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff, tx rate 30 (Mbps), max_tx_rate 30Mbps

$ ip link set dev enp196s0f0 vf 5 min 20
$ ip l show dev enp196s0f0
  vf 5     link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff, tx rate 30 (Mbps), max_tx_rate 30Mbps, min_tx_rate 20Mbps


The second command setting the min-BW rate doesn't remove the max-BW
rate.

However, the Pyroute2 command to set the VF rates requires to set both.
> ip.link('set', 'enp196s0f0', index=idx, {'max_tx_rate': 100, 'min_tx_rate': 20})


If one key is missing, the value will be set to zero (the QoS rule will be removed). E.g.:
> ip.link('set', 'enp196s0f0', index=idx, {'max_tx_rate': 100}) --> this command will set a max-BW of 100Mbps and will remove any min-BW rule already defined.

** Affects: neutron
     Importance: Undecided
     Assignee: Rodolfo Alonso (rodolfo-alonso-hernandez)
         Status: New

** Changed in: neutron
     Assignee: (unassigned) => Rodolfo Alonso (rodolfo-alonso-hernandez)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1962844

Title:
  [SR-IOV] QoS extension doesn't set max-tx-rate and min-tx-rate in the
  same port

Status in neutron:
  New

Bug description:
  The SR-IOV agent extension can handle max-BW and min-BW QoS rules, but
  currently doesn't apply both to the same port at the same time.

  The problem is how the Pyroute2 command is used. The "ip link" command allows to set "rate" and "min" rules in two independent commands. E.g.:
  $ ip link set dev enp196s0f0 vf 5 rate 30
  $ ip l show dev enp196s0f0
    vf 5     link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff, tx rate 30 (Mbps), max_tx_rate 30Mbps

  $ ip link set dev enp196s0f0 vf 5 min 20
  $ ip l show dev enp196s0f0
    vf 5     link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff, tx rate 30 (Mbps), max_tx_rate 30Mbps, min_tx_rate 20Mbps


  The second command setting the min-BW rate doesn't remove the max-BW
  rate.

  However, the Pyroute2 command to set the VF rates requires to set both.
  > ip.link('set', 'enp196s0f0', index=idx, {'max_tx_rate': 100, 'min_tx_rate': 20})


  If one key is missing, the value will be set to zero (the QoS rule will be removed). E.g.:
  > ip.link('set', 'enp196s0f0', index=idx, {'max_tx_rate': 100}) --> this command will set a max-BW of 100Mbps and will remove any min-BW rule already defined.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1962844/+subscriptions



Follow ups