yahoo-eng-team team mailing list archive

[OpenStack Infra <1965530@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/834345
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/90bd5dc71ecd4891fcd9292d56726f034a59fbdf
Submitter: "Zuul (22348)"
Branch:    master

commit 90bd5dc71ecd4891fcd9292d56726f034a59fbdf
Author: Miguel Lavalle <mlavalle@xxxxxxxxxx>
Date:   Fri Mar 18 13:03:22 2022 -0500

    Remove incorrect character in f-string
    
    Patch [1] switched to f-strings, unwillingly introducing a 'i' to an
    ip address. This change corrects that error
    
    [1] https://review.opendev.org/c/openstack/ovn-octavia-provider/+/816829
    
    Closes-Bug: #1965530
    Change-Id: I832780660a3658552dc8fb50c3e232306e1fa110


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1965530

Title:
  ovn-octavia-provider health monitoring fails because doesn't set the
  correct source IP address for OVN health check

Status in neutron:
  Fix Released

Bug description:
  Hello all,

  IT seems the health checking feature of ovn octavia provider is broken
  and all service monitors show offline status because of a typo in
  https://opendev.org/openstack/ovn-octavia-
  provider/src/commit/1b212ec54fa336cc7a22a502ad3d0ce39658138e/ovn_octavia_provider/helper.py#L2171

  Note the "i" prepended in the IP address in member_src +=
  f'i{hm_source_ip}'

  This causes the IP string to be casted including the "i" which give a
  random IP address for health check source, which in turn cause the
  response packet of the checked backend to be sent to the gateway MAC
  instead of the health check monitor source MAC defined in NB_Global
  options:svc_monitor_mac. The monitor does not get the check response
  and fails.

  The very simple fix is to remove this "i" letter to set the correct
  source IP address for the monitor.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1965530/+subscriptions