yahoo-eng-team team mailing list archive

[OpenStack Infra <1966354@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/834874
Committed: https://opendev.org/openstack/neutron/commit/cc50b45ca3c3e0f06034b4f1af581b83359e6172
Submitter: "Zuul (22348)"
Branch:    master

commit cc50b45ca3c3e0f06034b4f1af581b83359e6172
Author: zhouhenglc <zhouhenglc@xxxxxxxxxx>
Date:   Wed Mar 23 21:11:21 2022 +0800

    [test][unit]creating resources support set project_id
    
    To write a new unit test, need to set "project_id", and then
    use the discarded "tenant_id" is not appropriate.
    
    this patch updated creating resources method, both "project_id"
    and "tenant_id" are acceptable. of course, "project_id" priority.
    
    Closes-bug: #1966354
    
    Change-Id: Ic24f03da169dd3d1549b05b35ec77d3e9a25f17b


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1966354

Title:
  [test][unit] The method of creating  resources does not support
  setting project_ id

Status in neutron:
  Fix Released

Bug description:
  Some basic unit test classes in neutron， contain basic methods for creating resources, which are often referenced by other unit tests.
  eg:
  MeteringPluginDbTestCaseMixin.metering_label
  MeteringPluginDbTestCaseMixin.metering_label_rule
  NeutronDbPluginV2TestCase.network
  NeutronDbPluginV2TestCase.subnet
  NeutronDbPluginV2TestCase.subnetpool
  NeutronDbPluginV2TestCase.port
  AddressScopeTestCase.address_scope
  L3NatExtensionTestCase.router

  these methods only distinguish parameter "tenant_id", if the parameter "project_id" passed into, will raise error or not working.
  to write a new unit test, need to set "project_id", and then use the discarded "tenant_id" is not appropriate.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1966354/+subscriptions