yahoo-eng-team team mailing list archive

[OpenStack Infra <1967881@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/836656
Committed: https://opendev.org/openstack/neutron/commit/3a81b051d4a8e6f63f8da211816d0dbda62aee17
Submitter: "Zuul (22348)"
Branch:    master

commit 3a81b051d4a8e6f63f8da211816d0dbda62aee17
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Tue Apr 5 13:48:05 2022 +0000

    [SR-IOV] Default "propagate_uplink_status" flag to True
    
    Extension "uplink-status-propagation" does not allow to modify existing
    ports. This extension only enables the creation of new ports with
    this new flag.
    
    Similar to [1], this patch changes the default behaviour of the
    exiting ports: if no "propagate_uplink_status" flag is present, "True"
    is returned now. The aim of this change is to enable this feature for
    all existing ports, that is usually the aim of an administrator when
    enables this extension.
    
    [1]https://bugs.launchpad.net/neutron/+bug/1888487
    
    Closes-Bug: #1967881
    Related-Bug: #1888487
    
    Change-Id: Ica5b76e0a9a5ae12f764c66be259d7f3cd5b248b


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1967881

Title:
  [SR-IOV] Before enabling "uplink_status_propagation", ports are not
  created with this flag

Status in neutron:
  Fix Released

Bug description:
  Port extension "uplink_status_propagation" enables the creation of a
  port child register "portuplinkstatuspropagation". This register
  contains the flag "propagate_uplink_status". This flag is set by
  default as True when a port is created.

  The problem this bug presents is with the existing ports before
  enabling the extension. Those ports don't have any
  "portuplinkstatuspropagation" register associated. The extension will
  populate the port dictionary with the value of
  "propagate_uplink_status"; in case of not having this flag, the value
  will be "False".

  This bug proposes something similar to [2]. This patch set the default
  value of the flag to "True" for new ports. In this case, the proposal
  will affect existing ports **without** "portuplinkstatuspropagation"
  registers: if the Neutron DB port does not have this flag, return a
  "True" value. The aim of this proposal aligns with [2][3] goal, if an
  admin enables this feature, it is because he/she wants to have this
  feature enabled in all ports.

  
  [1]https://github.com/openstack/neutron/blob/3615cd85a4cc6aeecf7f066c4eb21c3cdca71d4c/neutron/db/uplink_status_propagation_db.py#L31-L33
  [2]https://review.opendev.org/c/openstack/neutron-lib/+/744208
  [3]https://bugs.launchpad.net/neutron/+bug/1888487

  
  Related bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2070629

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1967881/+subscriptions