yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #88631
[Bug 1968206] Re: [sriov]: set_device_rate() takes 3 positional arguments but 4 were given
Reviewed: https://review.opendev.org/c/openstack/neutron/+/837092
Committed: https://opendev.org/openstack/neutron/commit/837fda7566fc8d2344d68468be7717563e13008c
Submitter: "Zuul (22348)"
Branch: master
commit 837fda7566fc8d2344d68468be7717563e13008c
Author: elajkat <lajos.katona@xxxxxxxx>
Date: Fri Apr 8 09:29:14 2022 +0200
Change set_device_rate calls according to new signature
[1] changed the signature of set_device_rate to be alligned with how
pyroute2 expects rate parameters, some method which calls
set_device_rate needs to be changed also to use the new dict format for
calling it.
[1]: https://review.opendev.org/q/Ibbb6d938355440c42850812e368224b76b1fce19
Related-Bug: #1962844
Closes-Bug: #1968206
Change-Id: I7256747f45308b011edbb0f8c802439ea277423d
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1968206
Title:
[sriov]: set_device_rate() takes 3 positional arguments but 4 were
given
Status in neutron:
Fix Released
Bug description:
https://review.opendev.org/q/Ibbb6d938355440c42850812e368224b76b1fce19 (
[SR-IOV] Fix QoS extension to set min/max values) seems introduced an issue with sriov ports, see the below traceback:
https://paste.opendev.org/show/bhQw8reMUZIQNSiWmDHc/
The original bug: https://bugs.launchpad.net/neutron/+bug/1962844
The issue seems to be that the signature was not changed everywhere to
the new dict format.
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1968206/+subscriptions
References