← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1967839] Re: [L3] NDP extension not handing "ha_state_change" correctly

 

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/836581
Committed: https://opendev.org/openstack/neutron/commit/d73ec5000bcb3a6add158eb50057af0a619c7f7f
Submitter: "Zuul (22348)"
Branch:    master

commit d73ec5000bcb3a6add158eb50057af0a619c7f7f
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Mon Mar 21 04:48:11 2022 +0000

    [L3] Fix "NDPProxyAgentExtension.ha_state_change" call
    
    The parameter "data" passed to the method "ha_state_change" is not
    a router but a dictionary with "router_id" info.
    
    The method "NDPProxyAgentExtension._process_router" requires the
    router ID and the "enable_ndp_proxy" value, stored in the agent
    router cache.
    
    Closes-Bug: #1967839
    Related-Bug: #1877301
    Change-Id: Iab163e69f7e3641e2e1a451374231b6ccfa74c3e


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1967839

Title:
  [L3] NDP extension not handing "ha_state_change" correctly

Status in neutron:
  Fix Released

Bug description:
  The L3 extension NDP proxy is not handling the "ha_state_change" call
  correctly. From the functional test logs: [1].

  The method "NDPProxyAgentExtension._process_router" is retrieving the
  router ID from "data" dictionary using "id" key [2], instead of
  "router_id" [3].

  
  [1]https://paste.opendev.org/show/bkBUKu9WfB1u84BX5IvV/
  [2]https://github.com/openstack/neutron/blob/3615cd85a4cc6aeecf7f066c4eb21c3cdca71d4c/neutron/agent/l3/extensions/ndp_proxy.py#L351
  [3]https://github.com/openstack/neutron/blob/3615cd85a4cc6aeecf7f066c4eb21c3cdca71d4c/neutron/agent/l3/ha.py#L185

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1967839/+subscriptions



References