yahoo-eng-team team mailing list archive

[Rodolfo Alonso <1973049@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

This is a recurrent problem in the Neutron server when updating a
resource that has "standardattributes". If a concurrent update is done,
the DB (SQLAlchemy) will return a "StaleDataError" exception. E.g.: [1]

"""
UPDATE statement on table 'standardattributes' expected to update 1 row(s); 0 were matched.
"""

In this case, the whole transaction is retried. We should avoid retrying
any DB operation if this error happens. This retry decorator is
affecting some operations with [2] in place, as reported in [3].

NOTE: check the ``StandardAttribute.__mapper_args__`` parameters,
probably deleting "version_id_col".

[1]https://paste.opendev.org/show/b6xIzuXLgswCpuQeEr6i/
[2]https://review.opendev.org/c/openstack/neutron-lib/+/828738
[3]https://review.opendev.org/c/openstack/neutron/+/841246

** Affects: neutron
     Importance: Undecided
     Assignee: Rodolfo Alonso (rodolfo-alonso-hernandez)
         Status: New

** Changed in: neutron
     Assignee: (unassigned) => Rodolfo Alonso (rodolfo-alonso-hernandez)

** Description changed:

  This is a recurrent problem in the Neutron server when updating a
  resource that has "standardattributes". If a concurrent update is done,
  the DB (SQLAlchemy) will return a "StaleDataError" exception. E.g.: [1]
  
  """
  UPDATE statement on table 'standardattributes' expected to update 1 row(s); 0 were matched.
  """
  
- 
- In this case, the whole transaction is retried. We should avoid retrying any DB operation if this error happens.
+ In this case, the whole transaction is retried. We should avoid retrying
+ any DB operation if this error happens. This retry decorator is
+ affecting some operations with [2] in place, as reported in [3].
  
  NOTE: check the ``StandardAttribute.__mapper_args__`` parameters,
  probably deleting "version_id_col".
  
  [1]https://paste.opendev.org/show/b6xIzuXLgswCpuQeEr6i/
+ [2]https://review.opendev.org/c/openstack/neutron-lib/+/828738
+ [3]https://review.opendev.org/c/openstack/neutron/+/841246

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1973049

Title:
  Skip DB retry when update on "standardattributes" fails

Status in neutron:
  New

Bug description:
  This is a recurrent problem in the Neutron server when updating a
  resource that has "standardattributes". If a concurrent update is
  done, the DB (SQLAlchemy) will return a "StaleDataError" exception.
  E.g.: [1]

  """
  UPDATE statement on table 'standardattributes' expected to update 1 row(s); 0 were matched.
  """

  In this case, the whole transaction is retried. We should avoid
  retrying any DB operation if this error happens. This retry decorator
  is affecting some operations with [2] in place, as reported in [3].

  NOTE: check the ``StandardAttribute.__mapper_args__`` parameters,
  probably deleting "version_id_col".

  [1]https://paste.opendev.org/show/b6xIzuXLgswCpuQeEr6i/
  [2]https://review.opendev.org/c/openstack/neutron-lib/+/828738
  [3]https://review.opendev.org/c/openstack/neutron/+/841246

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1973049/+subscriptions