← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1975837] [NEW] ``ovn_revision_bumbers_db._ensure_revision_row_exist`` is mixing DB contexts

 

Public bug reported:

The method ``ovn_revision_bumbers_db._ensure_revision_row_exist``
creates a DB reader decorator to check if the "OVNRevisionNumbers"
register exists, based on the resource ID. If it doesn't, the method
calls ``create_initial_revision``, that creates a DB writer context
inside the reader one.

In older versions (networking-ovn Train for example), the error is even
worst, as described in [1]. Inside the DB reader context we catch a DB
exception without ending this transaction or rolling back. Then we call
the ``create_initial_revision`` method, opening a new write context
inside the reader one.

Related Bugzilla: [1]

[1]https://bugzilla.redhat.com/show_bug.cgi?id=2090757

** Affects: neutron
     Importance: High
     Assignee: Rodolfo Alonso (rodolfo-alonso-hernandez)
         Status: Confirmed

** Changed in: neutron
     Assignee: (unassigned) => Rodolfo Alonso (rodolfo-alonso-hernandez)

** Changed in: neutron
   Importance: Undecided => High

** Changed in: neutron
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1975837

Title:
  ``ovn_revision_bumbers_db._ensure_revision_row_exist`` is mixing DB
  contexts

Status in neutron:
  Confirmed

Bug description:
  The method ``ovn_revision_bumbers_db._ensure_revision_row_exist``
  creates a DB reader decorator to check if the "OVNRevisionNumbers"
  register exists, based on the resource ID. If it doesn't, the method
  calls ``create_initial_revision``, that creates a DB writer context
  inside the reader one.

  In older versions (networking-ovn Train for example), the error is
  even worst, as described in [1]. Inside the DB reader context we catch
  a DB exception without ending this transaction or rolling back. Then
  we call the ``create_initial_revision`` method, opening a new write
  context inside the reader one.

  Related Bugzilla: [1]

  [1]https://bugzilla.redhat.com/show_bug.cgi?id=2090757

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1975837/+subscriptions



Follow ups