← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1956983] Re: Consider making upgrade check for old computes a failure

 

Reviewed:  https://review.opendev.org/c/openstack/nova/+/845262
Committed: https://opendev.org/openstack/nova/commit/9af4c6115fcfce9c76a1e7fd5b93bb43cec66a4d
Submitter: "Zuul (22348)"
Branch:    master

commit 9af4c6115fcfce9c76a1e7fd5b93bb43cec66a4d
Author: Pierre Riteau <pierre@xxxxxxxxxxxx>
Date:   Thu Jun 9 20:56:26 2022 +0200

    Change TooOldComputeService upgrade check code to failure
    
    The TooOldComputeService upgrade check currently produces a warning,
    which may be missed if the upgrade process only checks the exit code of
    the upgrade check command.
    
    Since this can lead to Nova control services failing to start, make the
    upgrade check a failure instead, so it results in a non-zero exit code.
    
    Closes-Bug: #1956983
    Change-Id: Ia3ce6a0b0b810667ac0a66502a43038fe43c5aed


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1956983

Title:
  Consider making upgrade check for old computes a failure

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Currently, the upgrade check for older than N-1 computes only produces a warning.
  For example:

  Check: Older than N-1 computes
  Result: Warning
  Details: Current Nova version does not support computes older than
    Victoria but the minimum compute service level in your
    system is 30 and the oldest supported service level is 52.

  If this is overlooked, Nova services will fail to start after upgrade.
  With Nova API down, the old services cannot be removed without
  database edits.

  Is there a specific reason to keep this check as a warning rather than
  a failure?

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1956983/+subscriptions



References