yahoo-eng-team team mailing list archive

[Balazs Gibizer <1981080@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Since we reenabled greendns with[1] nova functional test prints a
warning at startup:

2022-07-08 11:03:40.374564 | ubuntu-focal | Modules with known eventlet
monkey patching issues were imported prior to eventlet monkey patching:
urllib3. This warning can usually be ignored if the caller is only
importing and not executing nova code.

This is coming from [2]. It seems we think that urllib3 has monkey
patching issues as reported in [3].

Based on tracing the imports eventlet import urllib3 for the greendns
feature.

So I'm wondering if by reenabling greendns with [1] we actually
reintroduced [3]. If yes, then we probably need to revert [1]. If not,
then we probably remove urllib from our problems list in [2].

Example logs are in [4].

[1]https://review.opendev.org/c/openstack/nova/+/830966
[2]https://github.com/openstack/nova/blob/90c0c687a487601e009c72f60c88be92f6a55264/nova/monkey_patch.py#L76
[3]https://bugs.launchpad.net/nova/+bug/1808951
[4]https://zuul.opendev.org/t/openstack/build/5ff0d13fd8db4719bb0407b42c510e09/log/job-output.txt#1706-1714

** Affects: nova
     Importance: Undecided
         Status: New

** Description changed:

  Since we reenabled greendns with[1] nova functional test prints a
  warning at startup:
  
  2022-07-08 11:03:40.374564 | ubuntu-focal | Modules with known eventlet
  monkey patching issues were imported prior to eventlet monkey patching:
  urllib3. This warning can usually be ignored if the caller is only
  importing and not executing nova code.
  
  This is coming from [2]. It seems we think that urllib3 has monkey
  patching issues as reported in [3].
  
  Based on tracing the imports eventlet import urllib3 for the greendns
  feature.
  
  So I'm wondering if by reenabling greendns with [1] we actually
  reintroduced [3]. If yes, then we probably need to revert [1]. If not,
  then we probably remove urllib from our problems list in [2].
  
- 
+ Example logs are in [4].
  
  [1]https://review.opendev.org/c/openstack/nova/+/830966
  [2]https://github.com/openstack/nova/blob/90c0c687a487601e009c72f60c88be92f6a55264/nova/monkey_patch.py#L76
  [3]https://bugs.launchpad.net/nova/+bug/1808951
+ [4]https://zuul.opendev.org/t/openstack/build/5ff0d13fd8db4719bb0407b42c510e09/log/job-output.txt#1706-1714

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1981080

Title:
  Modules with known eventlet monkey patching issues were imported prior
  to eventlet monkey patching: urllib3

Status in OpenStack Compute (nova):
  New

Bug description:
  Since we reenabled greendns with[1] nova functional test prints a
  warning at startup:

  2022-07-08 11:03:40.374564 | ubuntu-focal | Modules with known
  eventlet monkey patching issues were imported prior to eventlet monkey
  patching: urllib3. This warning can usually be ignored if the caller
  is only importing and not executing nova code.

  This is coming from [2]. It seems we think that urllib3 has monkey
  patching issues as reported in [3].

  Based on tracing the imports eventlet import urllib3 for the greendns
  feature.

  So I'm wondering if by reenabling greendns with [1] we actually
  reintroduced [3]. If yes, then we probably need to revert [1]. If not,
  then we probably remove urllib from our problems list in [2].

  Example logs are in [4].

  [1]https://review.opendev.org/c/openstack/nova/+/830966
  [2]https://github.com/openstack/nova/blob/90c0c687a487601e009c72f60c88be92f6a55264/nova/monkey_patch.py#L76
  [3]https://bugs.launchpad.net/nova/+bug/1808951
  [4]https://zuul.opendev.org/t/openstack/build/5ff0d13fd8db4719bb0407b42c510e09/log/job-output.txt#1706-1714

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1981080/+subscriptions