← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1983753] Re: Resize with changing pci alias schedules accoring to the old flavor

 

*** This bug is a duplicate of bug 1941005 ***
    https://bugs.launchpad.net/bugs/1941005

Reviewed:  https://review.opendev.org/c/openstack/nova/+/852296
Committed: https://opendev.org/openstack/nova/commit/a93092e0d5c1483f9ad48276708ee35c54ce44fe
Submitter: "Zuul (22348)"
Branch:    master

commit a93092e0d5c1483f9ad48276708ee35c54ce44fe
Author: Balazs Gibizer <gibi@xxxxxxxxxx>
Date:   Sat Aug 6 16:09:54 2022 +0200

    Update RequestSpec.pci_request for resize
    
    Nova uses the RequestSpec.pci_request in the PciPassthroughFilter to
    decide if the PCI devicesm, requested via the pci_alias in the flavor
    extra_spec, are available on a potential target host. During resize the
    new flavor might contain different pci_alias request than the old flavor
    of the instance. In this case Nova should use the pci_alias from the new
    flavor to scheduler the destination host of the resize. However this
    logic was missing and Nova used the old pci_request value based on the
    old flavor. This patch adds the missing logic.
    
    Closes-Bug: #1983753
    Closes-Bug: #1941005
    Change-Id: I73c9ae27e9c42ee211a53bed3d849650b65f08be


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1983753

Title:
  Resize with changing pci alias schedules accoring to the old flavor

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Nova does not consider the pci_alias from the new flavor extra_specs
  during the scheduling of the resize. The new pci_request only applied
  by the resource_tracker during the move claim[1].

  This leads to a behavior where during the scheduling of the resize
  nova selects the target host according to the old flavor's pci_request
  but then at the selected host it will allocate PCI devices properly
  based on the new flavor.

  [1]
  https://github.com/openstack/nova/blob/adeea3d5e7d7337d2817dd5c46334c76c05995ef/nova/compute/resource_tracker.py#L287-L299

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1983753/+subscriptions



References