yahoo-eng-team team mailing list archive

[OpenStack Infra <1984238@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/852775
Committed: https://opendev.org/openstack/neutron-dynamic-routing/commit/d98b177a26960732c775efe49eb52921e121358e
Submitter: "Zuul (22348)"
Branch:    master

commit d98b177a26960732c775efe49eb52921e121358e
Author: Takashi Kajinami <tkajinam@xxxxxxxxxx>
Date:   Thu Aug 11 00:34:30 2022 +0900

    [sqlalchemy-20] Add (still) missing DB context decorator
    
    This fixes one query still being executed without context decorator,
    which is causing the warning messages.
    
    Related-Bug: #1980671
    Closes-Bug: #1984238
    Change-Id: I3eba9c919e153dd253988fee31a7cebaf3cad773


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1984238

Title:
  neutron-dynamic-routing: Continuous warning because of missing context
  wrapper

Status in neutron:
  Fix Released

Bug description:
  It seems the fix for https://bugs.launchpad.net/neutron/+bug/1980671
  was incomplete.

  In Puppet OpenStack job we observe the following WARNING when neutron-
  dynamic-routing is enabled

  https://zuul.opendev.org/t/openstack/build/9033dba56cd843e8a022a9f11a11f69a

  https://597ec4b4da1176461210-f1e10e895ca9a37e1229881907aff07c.ssl.cf1.rackcdn.com/845984/2/check/puppet-
  openstack-integration-7-scenario004-tempest-
  centos-9-stream/9033dba/logs/neutron/server.txt

  ```
  2022-08-10 01:35:26.723 102553 WARNING neutron.objects.base [None req-4a9650ba-3041-46db-98c1-af8c625df7c9 85c0a6ad83f24770b3cf565b324d33fd 414c0188246e442c8f0baf6ae86e1d7d - - default default] ORM session: SQL execution without transacti
  on in progress, traceback:
    File "/usr/lib/python3.9/site-packages/eventlet/greenthread.py", line 221, in main
      result = function(*args, **kwargs)
    File "/usr/lib/python3.9/site-packages/eventlet/wsgi.py", line 837, in process_request
      proto.__init__(conn_state, self)
  ...
    File "/usr/lib/python3.9/site-packages/neutron/db/l3_dvr_db.py", line 1411, in update_floatingip
      old_floatingip, floatingip = self._update_floatingip(
    File "/usr/lib/python3.9/site-packages/neutron/db/l3_db.py", line 1519, in _update_floatingip
      registry.publish(
    File "/usr/lib/python3.9/site-packages/neutron_lib/callbacks/registry.py", line 54, in publish
      _get_callback_manager().publish(resource, event, trigger, payload=payload)
    File "/usr/lib/python3.9/site-packages/neutron_lib/db/utils.py", line 105, in _wrapped
      return function(*args, **kwargs)
    File "/usr/lib/python3.9/site-packages/neutron_lib/callbacks/manager.py", line 150, in publish
      errors = self._notify_loop(resource, event, trigger, payload)
    File "/usr/lib/python3.9/site-packages/neutron_lib/callbacks/manager.py", line 181, in _notify_loop
      callback(resource, event, trigger, payload=payload)
    File "/usr/lib/python3.9/site-packages/neutron_dynamic_routing/services/bgp/bgp_plugin.py", line 257, in floatingip_update_callback
      next_hop = self._get_fip_next_hop(
    File "/usr/lib/python3.9/site-packages/neutron_dynamic_routing/db/bgp_db.py", line 1090, in _get_fip_next_hop
      router = self._get_router(context, router_id)
    File "/usr/lib/python3.9/site-packages/neutron_dynamic_routing/db/bgp_db.py", line 1084, in _get_router
      router = model_query.get_by_id(context, l3_db.Router, router_id)
    File "/usr/lib/python3.9/site-packages/neutron_lib/db/model_query.py", line 169, in get_by_id
      return query.filter(model.id == object_id).one()
    File "/usr/lib64/python3.9/site-packages/sqlalchemy/orm/query.py", line 2865, in one
      return self._iter().one()
    File "/usr/lib64/python3.9/site-packages/sqlalchemy/orm/query.py", line 2903, in _iter
      result = self.session.execute(
    File "/usr/lib64/python3.9/site-packages/sqlalchemy/orm/session.py", line 1693, in execute
      result = fn(orm_exec_state)
  ```

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1984238/+subscriptions