yahoo-eng-team team mailing list archive

[OpenStack Infra <1986644@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/853259
Committed: https://opendev.org/openstack/neutron/commit/800f863ccc502b334cb2dd79ec54066440e43e27
Submitter: "Zuul (22348)"
Branch:    master

commit 800f863ccc502b334cb2dd79ec54066440e43e27
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Wed Aug 10 14:58:07 2022 +0200

    Stop returning unneeded information from "pyroute2" method calls
    
    "pyroute2" methods can include some objects that don't implement
    any serialization method (e.g.: "nla_slot" [1]). In those methods
    that require an output ("get_*", "list_*", etc.), the Neutron
    IP library formats the output inside the privsep context only to
    contain serializable objects.
    
    However this library is also returning the blobs returned from
    the "pyroute2" library, without parsing and formatting, from
    methods that don't require an output ("set_*", "add_*", "delete_*",
    etc.). This patch removes the "return" statement from those methods
    because the output is not required and to avoid issues like those
    reported in the related bug.
    
    [1]https://github.com/svinota/pyroute2/blob/8716b9b5c03c96e335cf864547541ff81aff7f60/pyroute2/netlink/__init__.py#L1754
    
    Closes-Bug: #1986644
    Change-Id: I491dbdabfda0ca010ca56355b71dfe150ed71a71


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1986644

Title:
  pyroute2 master failing in CI: TypeError: can not serialize 'nla_slot'
  object

Status in neutron:
  Fix Released

Bug description:
  pyroute2 master version (>0.7.2) is failing in the CI with the
  following error: https://paste.opendev.org/show/bON9PuKjYj6vlxA8942A/

  Logs:
  https://401a884445a9c5667b12-ea63ef32363ab40ce9c3b69f87c5f829.ssl.cf2.rackcdn.com/periodic/opendev.org/openstack/neutron/master/neutron-
  functional-with-pyroute2-master/ec0243c/testr_results.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1986644/+subscriptions